-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
happo dev
command not supported with some plugins
#88
Comments
I think the |
@monokrome They definitely are. Getting I've been thinking about a slightly different dev experience for Storybook projects with happo where we would have a button in the Storybook UI to quickly check what this components look like in different browsers, and then you can incrementally make changes to the component and get diffs along the way. Do you think this would be interesting? If so, maybe we can outline/sketch out the feature here? |
I've had an initial look at the outlined dev experience (button in the Storybook UI) and these are some thoughts and challenges:
|
By the way, this is what I had in mind for the Storybook UI (in its simplest form): If you hit that button, we would show one or more screenshots in that box. If you hit it again, we would compare the new screenshots with the previous ones. There are of course other features we could consider down the road. Here are some ideas:
|
Currently, none of the
happo-plugin-storybook
andhappo-plugin-gatsby
plugins work when runninghappo dev
. The dev command mostly makes sense when you have your own-happo.js
files, so it might not make sense to fix support -- we might just have to bail with some useful error message.The text was updated successfully, but these errors were encountered: