Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for retries ignore L7 retries #412

Closed
roidelapluie opened this issue Dec 17, 2019 · 1 comment
Closed

Documentation for retries ignore L7 retries #412

roidelapluie opened this issue Dec 17, 2019 · 1 comment
Labels
status: fixed This issue is a now-fixed bug. type: doc This issue is about the documentation.

Comments

@roidelapluie
Copy link
Contributor

haproxy/doc/configuration.txt

Lines 7798 to 7809 in 5060326

retries <value>
Set the number of retries to perform on a server after a connection failure
May be used in sections: defaults | frontend | listen | backend
yes | no | yes | yes
Arguments :
<value> is the number of times a connection attempt should be retried on
a server when a connection either is refused or times out. The
default value is 3.
It is important to understand that this value applies to the number of
connection attempts, not full requests. When a connection has effectively
been established to a server, there will be no more retry.

The documentation should be updated to reflect the fact that retries will happen on anything that retry-on is set to, not just connection failure.
@roidelapluie roidelapluie added status: needs-triage This issue needs to be triaged. type: bug This issue describes a bug. labels Dec 17, 2019
@roidelapluie roidelapluie changed the title Documentation for retries ignore L& retries Documentation for retries ignore L7 retries Dec 17, 2019
@capflam capflam added type: doc This issue is about the documentation. and removed type: bug This issue describes a bug. status: needs-triage This issue needs to be triaged. labels Dec 3, 2021
haproxy-mirror pushed a commit that referenced this issue Nov 25, 2022
@wtarreau
DOC: config: clarify the fact that "retries" is not just for connections
0b4a622 
In issue #412 it was rightfully reported that the wording in "retries"
still exclusively speaks about connection attempts, while since L7
retries with "retry-on" it's no longer a limitation. Let's update the
text.
@wtarreau wtarreau added the status: fixed This issue is a now-fixed bug. label Nov 25, 2022
@wtarreau
Copy link
Member

Finally fixed, thanks!

FireBurn pushed a commit to FireBurn/haproxy that referenced this issue Dec 3, 2022
@wtarreau @capflam
DOC: config: clarify the fact that "retries" is not just for connections
e29a4d1 
In issue haproxy#412 it was rightfully reported that the wording in "retries"
still exclusively speaks about connection attempts, while since L7
retries with "retry-on" it's no longer a limitation. Let's update the
text.

(cherry picked from commit 0b4a622)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
FireBurn pushed a commit to FireBurn/haproxy that referenced this issue Dec 6, 2022
@wtarreau @capflam
DOC: config: clarify the fact that "retries" is not just for connections
544f1f6 
In issue haproxy#412 it was rightfully reported that the wording in "retries"
still exclusively speaks about connection attempts, while since L7
retries with "retry-on" it's no longer a limitation. Let's update the
text.

(cherry picked from commit 0b4a622)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit e29a4d1)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
FireBurn pushed a commit to FireBurn/haproxy that referenced this issue Dec 10, 2022
@wtarreau @capflam
DOC: config: clarify the fact that "retries" is not just for connections
97e5517 
In issue haproxy#412 it was rightfully reported that the wording in "retries"
still exclusively speaks about connection attempts, while since L7
retries with "retry-on" it's no longer a limitation. Let's update the
text.

(cherry picked from commit 0b4a622)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit e29a4d1)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 544f1f6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit cc83488)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
FireBurn pushed a commit to FireBurn/haproxy that referenced this issue Dec 10, 2022
@wtarreau @capflam
DOC: config: clarify the fact that "retries" is not just for connections
a7456c9 
In issue haproxy#412 it was rightfully reported that the wording in "retries"
still exclusively speaks about connection attempts, while since L7
retries with "retry-on" it's no longer a limitation. Let's update the
text.

(cherry picked from commit 0b4a622)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit e29a4d1)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 544f1f6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit cc83488)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 97e5517)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
FireBurn pushed a commit to FireBurn/haproxy that referenced this issue Dec 10, 2022
@wtarreau @capflam
DOC: config: clarify the fact that "retries" is not just for connections
cc83488 
In issue haproxy#412 it was rightfully reported that the wording in "retries"
still exclusively speaks about connection attempts, while since L7
retries with "retry-on" it's no longer a limitation. Let's update the
text.

(cherry picked from commit 0b4a622)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit e29a4d1)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
(cherry picked from commit 544f1f6)
Signed-off-by: Christopher Faulet <cfaulet@haproxy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: fixed This issue is a now-fixed bug. type: doc This issue is about the documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@capflam @roidelapluie @wtarreau