Fix size/layout of struct needed for time stamping #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1029 +/- ##
===========================================
- Coverage 70.76% 70.75% -0.02%
===========================================
Files 79 79
Lines 7588 7592 +4
===========================================
+ Hits 5370 5372 +2
- Misses 2218 2220 +2 |
|
@Mergifyio update |
|
Command
|
|
This is done. |
tysonite
approved these changes
May 8, 2021
|
Indeed, this is an important fix. @hardbyte Could you have quick look? It isn't a large diff. |
hardbyte
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused the sub-second resolution to be cut off.
Fixes #1021. Also adds a regression test to catch this in the future and with other interfaces too.