Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can.Notifier enhancements #266

Merged
merged 8 commits into from
Mar 16, 2018
Merged

can.Notifier enhancements #266

merged 8 commits into from
Mar 16, 2018

Conversation

felixdivo
Copy link
Collaborator

@felixdivo felixdivo commented Feb 23, 2018 •
edited
Loading

This PR addresses #265. Basically adds a add_listener and a remove_listener method to can.Notifier.

Closes #265.

@felixdivo felixdivo added the api label Feb 23, 2018
@felixdivo felixdivo self-assigned this Feb 23, 2018
@felixdivo felixdivo mentioned this pull request Feb 24, 2018
Merged
@hardbyte
Copy link
Owner

Could you please add a couple of basic tests in https://github.com/hardbyte/python-can/blob/develop/test/listener_test.py

@felixdivo felixdivo added this to the 2.2 Release milestone Feb 25, 2018
@felixdivo
Copy link
Collaborator Author

Done. Shall I merge it into develop?

@felixdivo felixdivo merged commit 9db2b27 into develop Mar 16, 2018
@felixdivo felixdivo deleted the notifier-enhancements branch March 16, 2018 13:00
@hardbyte hardbyte mentioned this pull request Jun 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardbyte hardbyte Awaiting requested review from hardbyte

Assignees

@felixdivo felixdivo

Labels
api
Projects
None yet
Milestone
2.2 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@felixdivo @hardbyte