-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harfbuzz 2.6.1 - Can't be built on Mac OS with CMake #1966
Comments
How our bots couldn't found this :/ Please recheck and let us know. Thanks |
Hi there, thanks for the patch! As I'm currently in the process of updating harfbuzz for our project too, I tried to build the conan package by just applying it to 2.6.1. The MacOS build it runs into
for me now. I didn't try master, though. |
Something phishy going on with your setup. |
Our cmake uses harfbuzz.cc and that means font parsing structs will be on
the same file as hb-coretext header s are included, not sure about the fix
however other than prefixing remained font parsing related things with hb,
can just make sure same setup will be in the CI as we don't currently.
|
Thanks @ebraminio! Just added the two patches to my conan build and it compiles fine on all desired platforms. |
Oh thanks for checking it, I should've asked this myself actually, our CI
will make sure also amalgam buildability with hb-coretext on macOS from now
on.
در تاریخ شنبه ۱۴ سپتامبر ۲۰۱۹، ۱۸:۱۴ Cajus Pollmeier <
notifications@github.com> نوشت:
… Thanks @ebraminio <https://github.com/ebraminio>! Just added the two
patches to my conan build and it compiles fine on all desired platforms.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1966?email_source=notifications&email_token=AAGLPQL6MTZPREY7HGCZ33TQJTTEDA5CNFSM4IVANXZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6W4CBA#issuecomment-531480836>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGLPQOKPOKFVYQ3H6CAAITQJTTEDANCNFSM4IVANXZA>
.
|
Hi!
Thanks for release a new version of Harfbuzz!
When building on Mac Os + clang I have the follow error:
As you can see,
reference to 'Fixed' is ambiguous
is related to OSX CoreServices.Environment
Steps to reproduce
Of course, running
autogen.sh
it works, but it's not what I expect since from 2.4.0 I'm totally able to build using CMake only.Regards!
The text was updated successfully, but these errors were encountered: