Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from master fails with jhbuild #2752

Closed
jonas2515 opened this issue Nov 21, 2020 · 1 comment · Fixed by #2753
Closed

Build from master fails with jhbuild #2752

jonas2515 opened this issue Nov 21, 2020 · 1 comment · Fixed by #2753

Comments

@jonas2515
Copy link

jhbuild, a tool used by GNOME to build dependencies, fails to build harfbuzz from master for quite some time now, see https://gitlab.gnome.org/exalm/jhbuild-steps/-/issues/13.

The build fails because of an unused variable in src/hb-ot-shape-complex-use-machine.rl.

jhbuild builds with the arguments Dintrospection=enabled -Dgobject=enabled, maybe nobody is testing that combination?

@khaledhosny
Copy link
Collaborator

See adrian-thurston/ragel#56

But the generated files are included in the repository, and you can avoid regenerating them by not having ragel available to harfbuzz build at it has not been a build requirement for a long time (the files should not be regenerated if the source files are unchanged, but we couldn’t manage to make meson do this).

behdad pushed a commit that referenced this issue Nov 21, 2020
Hopefully fixes build with newer ragel.

adrian-thurston/ragel#56

Fixes #2752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants