Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amalgam builds are broken when both DirectWrite and Uniscribe are enabled #3070

Closed
khaledhosny opened this issue Jul 24, 2021 · 1 comment · Fixed by #3080
Closed

Amalgam builds are broken when both DirectWrite and Uniscribe are enabled #3070

khaledhosny opened this issue Jul 24, 2021 · 1 comment · Fixed by #3080

Comments

@khaledhosny
Copy link
Collaborator

Both files define structs with similar names since #3034. Need to move that code to a shared place and templatize it after all.

@behdad
Copy link
Member

behdad commented Jul 26, 2021

You can rename them to be unique for now.

I would do it but I can't build the directwrite code.

[15mins later]

I checked the code. I believe the DWrite structs were designed to be byte-compatible with the uniscribe ones. So I believe we can use non-templatized shared code. Just need to define two structs and have static asserts that their sizes match the uniscribe / dwrite one, and use those.

  • Unify OPENTYPE_FEATURE_RECORD and DWRITE_FONT_FEATURE into hb_ms_feature_t.
  • Unify TEXTRANGE_PROPERTIES and DWRITE_TYPOGRAPHIC_FEATURES into hb_ms_features_t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants