Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hb-ft transform issue #3790

Closed
behdad opened this issue Aug 19, 2022 · 2 comments
Closed

hb-ft transform issue #3790

behdad opened this issue Aug 19, 2022 · 2 comments

Comments

@behdad
Copy link
Member

behdad commented Aug 19, 2022

When fixing bitmap fonts with hb-ft, I made advance (and other) functions apply the FT_Face transform. Two issues with that:

  1. It was a breaking change for clients. Caused: Scaling change #3788

  2. As noted in that issue, this is also broken because GPOS doesn't take that transform into consideration.

The correct fix is to NOT do this; instead have hb-view apply the transform.

@behdad
Copy link
Member Author

behdad commented Aug 19, 2022

Umm. This is hard to fix.

@behdad
Copy link
Member Author

behdad commented Aug 19, 2022

I came up with a patch to conditionally apply the FT transform; only when we created the face.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant