Fix for: Warnings with gcc 8 and earlier #2972 #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thanks Thomas. I'll review tomorrow. |
|
Thanks @behdad ! |
sezero
added a commit
to libsdl-org/SDL_ttf
that referenced
this pull request
Jan 26, 2022
harfbuzz/harfbuzz#2973 harfbuzz/harfbuzz#2972 harfbuzz/harfbuzz@b54d9b6 Fixes the following warning: In file included from ../external/harfbuzz-2.8.0/src/hb-ot-shape-complex-use.cc:33:0: hb-ot-shape-complex-use-machine.rl: In instantiation of 'machine_index_t<Iter>::machine_index_t(const machine_index_t<Iter>&) [with Iter = hb_zip_iter_t<hb_iota_iter_t<unsigned int, unsigned int>, hb_filter_iter_t<hb_filter_iter_t<hb_zip_iter_t<hb_iota_iter_t<unsigned int, unsigned int>, hb_array_t<hb_glyph_info_t> >, find_syllables_use(hb_buffer_t*)::<lambda(const hb_glyph_info_t&)>, const<anonymous struct>&, 0u>, find_syllables_use(hb_buffer_t*)::<lambda(hb_pair_t<unsigned int, const hb_glyph_info_t&>)>, const<anonymous struct>&, 0u> >]': hb-ot-shape-complex-use-machine.rl:249:4: required from here hb-ot-shape-complex-use-machine.rl:194:2: warning: base class 'struct hb_iter_with_fallback_t<machine_index_t<hb_zip_iter_t<hb_iota_iter_t<unsigned int, unsigned int>, hb_filter_iter_t<hb_filter_iter_t<hb_zip_iter_t<hb_iota_iter_t<unsigned int, unsigned int>, hb_array_t<hb_glyph_info_t> >, find_syllables_use(hb_buffer_t*)::<lambda(const hb_glyph_info_t&)>, const<anonymous struct>&, 0u>, find_syllables_use(hb_buffer_t*)::<lambda(hb_pair_t<unsigned int, const hb_glyph_info_t&>)>, const<anonymous struct>&, 0u> > >, hb_pair_t<unsigned int, hb_pair_t<unsigned int, hb_glyph_info_t&> > >' should be explicitly initialized in the copy constructor [-Wextra]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please consider this fix for a build warning with gcc 8 and earlier. This causes problems in OpenJDK, see issue for details.
Thank you!
..Thomas