Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: harness.io/project-url has to end with / or the plugin doesn't work #70

Open
OrkoHunter opened this issue Feb 12, 2023 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@OrkoHunter
Copy link
Collaborator

OrkoHunter commented Feb 12, 2023

Expected Behavior

If I set a harness.io/project-url like https://app.harness.io/ng/#/account/accountID/cd/orgs/orgId/projects/projectId it should work.

Actual behavior

Plugin says no pipelines found.

Possible Implementation

https://github.com/harness/backstage-plugins/blob/666d1e859bf393d910361f6d6b347a8455527924/plugins/harness-ci-cd/src/components/ExecutionList/useProjectSlugEntity.tsx#LL16C50-L16C58

This regex should be updated. It expects a trailing /.

Either we append a trailing / when parsing the annotation ourselves in code. Or we update the regex to ignore the /.

cc @SarvJ1 @sarthakkasat @Debanitrkl @sandeepa-kv-jois

@OrkoHunter OrkoHunter added bug Something isn't working good first issue Good for newcomers labels Feb 12, 2023
@Debanitrkl
Copy link
Member

I have tried to replicate the same, using this catalog where the URL doesn't have the trailing / and it works fine.

@OrkoHunter
Copy link
Collaborator Author

Oh, interesting. Didn't expect it to be a one off glitch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants