Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests passing in Docker env #741

Merged
merged 4 commits into from
Dec 18, 2018

Conversation

rebeccacremona
Copy link
Contributor

  • installs node and npm packages
  • installs a local redis on the web/worker image for use by pytest-redis, which cannot be configured to use a remote redis at this time.....
  • uses named volumes and the :delegated to smooth heavy I/O. Might not be necessary for the local redis, but so far as I can tell harmless
  • does not ADD code to the image, since up-to-date code is supplied via mounted volumes

Note that tests pass even when the worker containers crash. (Perma doesn't test it's celery workers either)

Copy link
Contributor

@bensteinberg bensteinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

@bensteinberg bensteinberg merged commit 48e2034 into harvard-lil:develop Dec 18, 2018
@rebeccacremona rebeccacremona deleted the fix-dockerized-tests branch August 8, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants