feat: add gradle Helm dependency update task #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromy-cannon
requested review from
leninmehedy,
nathanklick and
deepak-swirlds
leninmehedy
reviewed
Oct 17, 2023
| @@ -59,8 +60,13 @@ tasks.register<HelmReleaseExistsTask>("helmNginxExists") { | |||
| release.set("nginx-release") | |||
| } | |||
|
|
|||
| tasks.register<HelmDependencyUpdateTask>("helmDependencyUpdate") { | |||
| chartName.set("../charts/hedera-network") | |||
There was a problem hiding this comment.
Is it possible to put "../charts/hedera-network" in a variable that can be used across the modules and its build.gradle.kts file?
There was a problem hiding this comment.
putting it in a variable is easy enough. However, this is the only place in gradle that it is used currently. It sounds like with your full cluster chart that this may not even get used with the gradle build script. We also have another PR that is about to merge that makes both fullstack-examples and fullstack-gradle-plugin separate projects.
leninmehedy
approved these changes
Oct 17, 2023
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
jeromy-cannon
force-pushed
the
00324-gradle-helm-dep-update
branch
from
4db8a1c
to
05aeac5
Compare
|
Kudos, SonarCloud Quality Gate passed! |
swirlds-automation
added a commit
that referenced
this pull request
Nov 3, 2023
## [0.12.0](v0.11.0...v0.12.0) (2023-11-03) ### Features * add a Gradle task for downloading executable for Kubernetes Kind ([#425](#425)) ([aaa9660](aaa9660)) * add fullstack-gradle-plugin project to GitHub workflow ([#421](#421)) ([7b717ab](7b717ab)) * add Gateway API route for Hedera Explorer ([#466](#466)) ([c53943c](c53943c)) * add Gradle build docker image tasks ([#408](#408)) ([338cf40](338cf40)) * add gradle Helm dependency update task ([#393](#393)) ([8e3ead5](8e3ead5)) * add gradle Helm release exists task ([#389](#389)) ([0b7ae17](0b7ae17)) * add gradle Helm test task ([#403](#403)) ([591cebb](591cebb)) * add helm chart tests for gateway api routes ([#345](#345)) ([3936a64](3936a64)) * add helm dependency update subcommand ([#377](#377)) ([2b3609d](2b3609d)) * add helm execution gradle task: HelmInstallChartTask ([#304](#304)) ([6a29222](6a29222)) * add helm execution gradle task: HelmUninstallChartTask ([#375](#375)) ([ba6cc63](ba6cc63)) * add helm list releases subcommand ([#380](#380)) ([53d092f](53d092f)) * add helm test subcommand with options ([#376](#376)) ([5d08a32](5d08a32)) * add ifExists option to Gradle Helm uninstall task ([#405](#405)) ([0726725](0726725)) * add minio operator to fullstack-cluster-setup chart ([#453](#453)) ([bf7f6ff](bf7f6ff)) * add prometheus operator to fullstack-cluster-setup ([#460](#460)) ([0313c3a](0313c3a)) * add skipIfExists option for Gradle Helm install task ([#406](#406)) ([ccfbabf](ccfbabf)) * add support for scheduling pods based on node labels, taints, and affinity ([#352](#352)) ([5dd625a](5dd625a)) * Adding fabric8 k8s library and helm client for use in Infra API ([#386](#386)) ([3049fe4](3049fe4)) * Adding topology model classes and junit annotation processing ([#383](#383)) ([9c6930e](9c6930e)) * apply nodeSelector and tolerations to all pods including proxies ([#384](#384)) ([40e737a](40e737a)) * **cli:** add traceId in CLI logs for easier debugging ([#449](#449)) ([a1693c7](a1693c7)) * **cli:** implement chart install, uninstall and upgrade commands ([#454](#454)) ([70fd199](70fd199)) * **cli:** implement cluster create and delete commands ([#446](#446)) ([78be823](78be823)) * **cli:** implement cluster setup command ([#452](#452)) ([89c2662](89c2662)) * **cli:** implement tests and dependency checks for init command ([#438](#438)) ([b69dd99](b69dd99)) * enhance Helm Install to support multiple set and values parameters ([#367](#367)) ([05444df](05444df)) * implement fullstack-cluster-setup chart for shared resources ([#363](#363)) ([e91f465](e91f465)) * parameterize the helm chart namespace value ([#351](#351)) ([6d1c0a5](6d1c0a5)) * scaffold fsnetman CLI with ES6 support ([#424](#424)) ([65e06d9](65e06d9)) * upgrade to gradle 8.4 ([#404](#404)) ([69e769d](69e769d)) * upgrade to org.gradlex:java-module-dependencies:1.4.1 ([#365](#365)) ([ba7c32b](ba7c32b)) ### Bug Fixes * avoid hardcoding mirror-node-explorer rest API in values.yaml ([#413](#413)) ([0fe58c7](0fe58c7)) * **cli:** encapsulate helm and kubectl commands and code cleanup ([#476](#476)) ([1b8c499](1b8c499)) * **cli:** encapsulate Kind commands in a separate wrapper class ([#468](#468)) ([6dc6025](6dc6025)) * store hedera-explorer chart as dependency until next official version is released ([#436](#436)) ([201bda5](201bda5)) * support deploying the chart with custom release name ([#412](#412)) ([619b42b](619b42b)) * uninstall envoy-gateway should also remove gateway-system namespace that it created ([#350](#350)) ([8a2f6e1](8a2f6e1)) * update KeyValuePair.equals to only compare key (not value) ([#347](#347)) ([28222e0](28222e0))
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues