Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): consolidate sidecar templates into the main network deployment template #743

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Feb 7, 2024

Description

This pull request changes the following:

  • consolidate sidecar templates into the main network deployment template in order to reduce multi-level templating

Related Issues

…emplate

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link

github-actions bot commented Feb 7, 2024

Unit Test Results

  26 files  ±0    26 suites  ±0   54s ⏱️ ±0s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ±0 

Results for commit d505c5b. ± Comparison against base commit 56402e0.

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56402e0) 67.51% compared to head (d505c5b) 67.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #743   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63           

Impacted file tree graph

@leninmehedy leninmehedy self-assigned this Feb 8, 2024
@jeromy-cannon jeromy-cannon merged commit b2872a1 into main Feb 8, 2024
18 checks passed
@jeromy-cannon jeromy-cannon deleted the 431-consolidate-sidecar-templates branch February 8, 2024 09:43
swirlds-automation added a commit that referenced this pull request Feb 9, 2024
## [0.21.0](v0.20.0...v0.21.0) (2024-02-09)

### Features

* **cli:** allow user to overriding properties files ([#738](#738)) ([72982a5](72982a5))

### Bug Fixes

* **chart:** consolidate sidecar templates into the main network deployment template ([#743](#743)) ([b2872a1](b2872a1))
* **chart:** disable backup-uploader ([#746](#746)) ([d2b7010](d2b7010))
* **chart:** use boolean values instead of string literals for booleans ([#744](#744)) ([d6567a9](d6567a9))
* **cli:** assign node account ID correctly base on start account ID ([#749](#749)) ([6149153](6149153))
* **cli:** solo init should reset cached config ([#737](#737)) ([911d25b](911d25b))
* fullstack cluster setup is not uninstalling correctly  ([#742](#742)) ([56402e0](56402e0))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Template] Consolidate sidecar templates
4 participants