Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): use selected paths for volumes mount under hgcapp directory #751

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Feb 9, 2024

Description

This pull request changes the following:

  • use selected paths for volumes under hgcapp directory for sidecars

Related Issues

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Copy link

github-actions bot commented Feb 9, 2024

Unit Test Results

  26 files    26 suites   53s ⏱️
109 tests 105 ✔️ 4 💤 0
110 runs  106 ✔️ 4 💤 0

Results for commit 94b3744.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b2872a1) 67.51% compared to head (94b3744) 67.51%.
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #751   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63           

Impacted file tree graph

@leninmehedy leninmehedy marked this pull request as ready for review February 9, 2024 04:59
@leninmehedy leninmehedy marked this pull request as draft February 9, 2024 05:00
@leninmehedy leninmehedy marked this pull request as ready for review February 12, 2024 05:17
Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jeromy-cannon jeromy-cannon merged commit e1d1c61 into main Feb 12, 2024
17 checks passed
@jeromy-cannon jeromy-cannon deleted the 745-update-bind-mounts-for-hgcapp-dir branch February 12, 2024 20:51
swirlds-automation added a commit that referenced this pull request Feb 23, 2024
## [0.22.0](v0.21.0...v0.22.0) (2024-02-23)

### Features

* allow user to create and update accounts with funds from treasury  ([#759](#759)) ([cd2567b](cd2567b))
* rekey special accounts at startup so they are not using genesis keys ([#733](#733)) ([096b5c3](096b5c3))

### Bug Fixes

* **chart:** use selected paths for volumes mount under hgcapp directory ([#751](#751)) ([e1d1c61](e1d1c61))
* **cli:** enhance file copy function of k8 class based on status code ([#758](#758)) ([e6b5602](e6b5602))
* **cli:** refactor config manager with each function having a single responsibility to avoid confusion ([#750](#750)) ([7f45864](7f45864))
* correct path names for volumes and upgrade minio ([#762](#762)) ([a8ec593](a8ec593))
* do version check for dependencies ([#755](#755)) ([520cb47](520cb47))
* **docker:** update location for entrypoint.sh ([#754](#754)) ([7cf02f6](7cf02f6))
* set the mirror node importer addressbook to an invalid value to prevent it from starting ([#777](#777)) ([a12cb1c](a12cb1c))
* use default values for flags during init ([#753](#753)) ([167fb3c](167fb3c))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Root Container]: Update bind mounts for individual directories under hgcapp
4 participants