Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rekey special accounts at startup so they are not using genesis keys #733

Merged
merged 29 commits into from
Feb 13, 2024
Merged

feat: rekey special accounts at startup so they are not using genesis keys #733

merged 29 commits into from
Feb 13, 2024

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Feb 5, 2024 •
edited
Loading

Description

This pull request changes the following:

  • rekey special accounts at startup so they are not using genesis keys
  • update haproxy.cfg to show more sysout to k8s logs
  • added account-id labels to:
    • charts/fullstack-deployment/templates/network-node-statefulset.yaml
    • charts/fullstack-deployment/templates/services/haproxy-svc.yaml
  • added sleep and check in solo/src/commands/node.mjs..checkNetworkNodePod to support user calling the solo node start after it was previously already running
  • refactored prompts.mjs to reduce duplication
  • added new methods to solo/src/core/k8.mjs
    • getSecret()
    • createSecret()

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Feb 5, 2024
@jeromy-cannon jeromy-cannon force-pushed the 00668-rekey-special-accounts branch 2 times, most recently from 85fc00f to b84d21b Compare February 5, 2024 14:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

Unit Test Results

  26 files  ±0    26 suites  ±0   53s ⏱️ -2s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 4f2d0da. ± Comparison against base commit 7f45864.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024 •
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f45864) 67.51% compared to head (4f2d0da) 67.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     hashgraph/full-stack-testing#733   +/-   ##
=========================================
  Coverage     67.51%   67.51%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1336     1336           
  Branches        157      157           
=========================================
  Hits            902      902           
  Misses          371      371           
  Partials         63       63

Impacted file tree graph

@jeromy-cannon jeromy-cannon force-pushed the 00668-rekey-special-accounts branch 6 times, most recently from a05d25e to d3dd103 Compare February 9, 2024 16:50
@jeromy-cannon jeromy-cannon marked this pull request as ready for review February 12, 2024 20:36
@jeromy-cannon
Squashed commit of the following:
6905805 
commit 829f4f1
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Fri Feb 2 14:45:05 2024 +0000

    saving current work

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 4d54a29
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Thu Feb 1 16:43:30 2024 +0000

    code updates account keys, timesout at 0.0.85

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 315b7b3
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Thu Feb 1 15:35:10 2024 +0000

    remove changes to node.mjs

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

commit 725c72f
Author: Jeromy Cannon <jeromy@swirldslabs.com>
Date:   Thu Feb 1 15:26:59 2024 +0000

    Squashed commit of the following:

    commit 15b9dff
    Author: Jeromy Cannon <jeromy@swirldslabs.com>
    Date:   Wed Jan 31 21:17:57 2024 +0000

        saving my work, in-progress

        Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

    commit 0384346
    Author: Jeromy Cannon <jeromy@swirldslabs.com>
    Date:   Wed Jan 31 20:02:41 2024 +0000

        created constant SYSTEM_ACCOUNTS

        Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

    commit 712e81c
    Author: Jeromy Cannon <jeromy@swirldslabs.com>
    Date:   Wed Jan 31 20:00:32 2024 +0000

        moved test inside of describe

        Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

    commit a81822e
    Author: Jeromy Cannon <jeromy@swirldslabs.com>
    Date:   Wed Jan 31 19:56:42 2024 +0000

        test: only genesis account should have genesis key

        Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

    commit 35cfe00
    Author: Jeromy Cannon <jeromy@swirldslabs.com>
    Date:   Wed Jan 31 19:55:52 2024 +0000

        added OPERATOR_PUBLIC_KEY

        Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

    Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
working version, but from e2e test
3ccfcc3 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
async
3722af4 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
caching changes
7ae8c72 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
saving state
e20b041 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
saving before rebase
c8df29c 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
retrieve service pod names and ports
c375ad7 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
code comments and documentation
53625d2 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
working version
16d0cd1 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
comments and todo
1be0680 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
update TODO
112e92b 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
added a sleep 5ms to test on pipeline
54f4621 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
updated for better error handling messages based on where the issue o…
0d4df37 
…ccurs.

Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
saving before refactor
d826eab 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
refactored getNodeClient
8d93e80 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
refactor getNodeClient, Promise.allSettled, updateAccountKeys
fae717f 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
committing current version
c1e712a 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
pushing latest version
987b1c1 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
renamed to avoid snyk white noise
63d1456 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
bump to 10 minutes for pipeline test
88c8d83 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
bump to 10 minutes for pipeline test
4b97730 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
committing current version
4497b9f 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
working version?
a9ffcab 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
add javadoc
6301647 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
updated flags.updateAccountKeys and refactored prompts to be more DRY
13e7f7d 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
reduced number of lines a bit
90307cf 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
updated todo, and added warning if not updating special account keys
a2cd8ac 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
fix
f386012 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@jeromy-cannon
fix
4f2d0da 
Signed-off-by: Jeromy Cannon <jeromy@swirldslabs.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jeromy-cannon jeromy-cannon merged commit 096b5c3 into main Feb 13, 2024
19 checks passed
@jeromy-cannon jeromy-cannon deleted the 00668-rekey-special-accounts branch February 13, 2024 09:09
swirlds-automation added a commit that referenced this pull request Feb 23, 2024
@swirlds-automation
chore(release): 0.22.0 [skip ci]
6d00a48 
## [0.22.0](v0.21.0...v0.22.0) (2024-02-23)

### Features

* allow user to create and update accounts with funds from treasury  ([#759](#759)) ([cd2567b](cd2567b))
* rekey special accounts at startup so they are not using genesis keys ([#733](#733)) ([096b5c3](096b5c3))

### Bug Fixes

* **chart:** use selected paths for volumes mount under hgcapp directory ([#751](#751)) ([e1d1c61](e1d1c61))
* **cli:** enhance file copy function of k8 class based on status code ([#758](#758)) ([e6b5602](e6b5602))
* **cli:** refactor config manager with each function having a single responsibility to avoid confusion ([#750](#750)) ([7f45864](7f45864))
* correct path names for volumes and upgrade minio ([#762](#762)) ([a8ec593](a8ec593))
* do version check for dependencies ([#755](#755)) ([520cb47](520cb47))
* **docker:** update location for entrypoint.sh ([#754](#754)) ([7cf02f6](7cf02f6))
* set the mirror node importer addressbook to an invalid value to prevent it from starting ([#777](#777)) ([a12cb1c](a12cb1c))
* use default values for flags during init ([#753](#753)) ([167fb3c](167fb3c))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leninmehedy leninmehedy leninmehedy approved these changes

@nathanklick nathanklick Awaiting requested review from nathanklick

Assignees

@jeromy-cannon jeromy-cannon

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: Reset default account keys after network deploy
4 participants
@jeromy-cannon @codecov-commenter @swirlds-automation @leninmehedy