Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancun Support HIPs #856

Closed
wants to merge 6 commits into from
Closed

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jan 12, 2024

Description:

Four hips that cover Hedera support for Cancun changes to the EVM.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 97bebf1
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/65aeeaae715e510008754889
😎 Deploy Preview https://deploy-preview-856--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for HIP for TLOAD, TSTORE and MCOPY

HIP/hip-0000-cancun-1.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-1.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-1.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-1.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-1.md Outdated Show resolved Hide resolved
No ideas were rejected around these three opcodes, aside from not supporting
Cancun features.

The idea of supporting [EIP-4788](https://eips.ethereum.org/EIPS/eip-4788):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to mention 4788 in this HIP.

This section can be reduced to just your opening sentence No ideas were rejected around these three opcodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these HIPs needs to addres beacon root. So I don't think simply deleting it is the right thing to do. Perhaps moving it.

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed "Add EVM compatibility for non-supported Cancun blob features." HIP doc

transaction is being simulated and reject the transaction before sending it to
the simulation and estimation engines.

### Hedera Activation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this section

HIP/hip-0000-cancun-2.md Show resolved Hide resolved
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed "Add Smart Contract Services Support for KZG Point Evaluation Precompiled Function"

HIP/hip-0000-cancun-3.md Outdated Show resolved Hide resolved
While Hedera will not be supporting most EIP-4844 features the KZG Point
Evaluation Precompile is cleanly severable from the other integrated features.
This precompile, when accompanied by the associated trusted setup, can be viewed
as a cryptographic primitive similar to ECDSA. The ability to proved subsets of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The ability to proved subsets..." needs to be clarified

HIP/hip-0000-cancun-3.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-3.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-3.md Show resolved Hide resolved
HIP/hip-0000-cancun-3.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed "Support Cancun Self-Destruct Semantics in Smart Contract Services"

HIP/hip-0000-cancun-4.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-4.md Outdated Show resolved Hide resolved
in my contracts to sweep out hbar while not destroying the contract.
* As a smart contract developer I want to be able to continue to use the
transient contract pattern and have it behave the same way prior to this HIP.
* As a HAPI user I want to be able to control my contract account in the same
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is an actual user story. Should be clear what flow should be possible or not possible

HIP/hip-0000-cancun-4.md Outdated Show resolved Hide resolved

### Hedera Services

Hedera services may need to be changed to ensure that the transaction processing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transient self-destructs should result in a ContractCreate and a ContractDelete synthetic transactions for network consistency.

HIP/hip-0000-cancun-4.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added working group suggestions based on previous conversations.
Please add anyone I left out based on design impact

HIP/hip-0000-cancun-1.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-2.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-3.md Outdated Show resolved Hide resolved
HIP/hip-0000-cancun-4.md Outdated Show resolved Hide resolved
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon
Copy link
Contributor Author

shemnon commented Jan 24, 2024

Closed in favor of #865, #866, #867, and #868

@shemnon shemnon closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants