Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HIP: Add Cancun KZG precompile #867

Merged
merged 3 commits into from Feb 14, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jan 24, 2024

Description:

EIP to add the KZG precompile from the Cancun fork.

Related issue(s):

Fixes #

Notes for reviewer:

This is one of four related HIPs for Cancun support

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

EIP to add the KZG precompile from the Cancun fork.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 8137074
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/65bd10ec8ee6b900084a0154
😎 Deploy Preview https://deploy-preview-867--hedera-hips.netlify.app/hip/hip-867
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shemnon shemnon changed the title Add Cancun KZG precompile Create HIP: Add Cancun KZG precompile Jan 24, 2024
@shemnon shemnon mentioned this pull request Jan 24, 2024
2 tasks
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Nana-EC
Nana-EC previously approved these changes Feb 2, 2024
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, 1 nit comment

HIP/hip-867.md Outdated Show resolved Hide resolved
gud english

Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggestion that a couple of more things be added to the references list of this HIP.

HIP/hip-867.md Show resolved Hide resolved
HIP/hip-867.md Show resolved Hide resolved
@shemnon shemnon merged commit c68b8cd into hashgraph:main Feb 14, 2024
6 checks passed
kantorcodes pushed a commit to kantorcodes/hedera-improvement-proposal that referenced this pull request Feb 16, 2024
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants