Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky subgraph test #1146

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Fix flaky subgraph test #1146

merged 2 commits into from
Apr 28, 2023

Conversation

georgi-l95
Copy link
Collaborator

@georgi-l95 georgi-l95 commented Apr 28, 2023

Description:
This PR adds a new step in the subgraph CI workflow, which generates the necessary types before starting the graph node and deploy the subgraph.
Also there is a bug in node version 18.16 (latest) which is being used here. This results in hardhat not being able to download the compiler and exiting with exitcode 0. More info here

Related issue(s):

Fixes #1143

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 requested a review from a team as a code owner April 28, 2023 08:58
@georgi-l95 georgi-l95 self-assigned this Apr 28, 2023
@georgi-l95 georgi-l95 linked an issue Apr 28, 2023 that may be closed by this pull request
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (a0694c5) 74.57% compared to head (5f4e3b8) 74.57%.

❗ Current head 5f4e3b8 differs from pull request most recent head cacde32. Consider uploading reports for the commit cacde32 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1146   +/-   ##
=======================================
  Coverage   74.57%   74.57%           
=======================================
  Files          31       31           
  Lines        2163     2163           
  Branches      426      426           
=======================================
  Hits         1613     1613           
  Misses        440      440           
  Partials      110      110           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@georgi-l95 georgi-l95 requested a review from Nana-EC April 28, 2023 11:43
@Nana-EC Nana-EC added bug Something isn't working limechain P2 process Build, test and deployment-process related tasks labels Apr 28, 2023
@Nana-EC Nana-EC added this to the 0.23.0 milestone Apr 28, 2023
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgi-l95 georgi-l95 merged commit 849dc4f into main Apr 28, 2023
22 checks passed
@georgi-l95 georgi-l95 deleted the 1143-flaky-subgraph-test branch April 28, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain P2 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Subgraph test
4 participants