Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename com.hedera.mirror to com.hedera.mirror.importer #402

Merged
merged 1 commit into from Nov 26, 2019

Conversation

steven-sheehy
Copy link
Member

Detailed description:
Rename com.hedera.mirror to com.hedera.mirror.importer

Which issue(s) this PR fixes:
Related to #359

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature P1 process Build, test and deployment-process related tasks labels Nov 26, 2019
@steven-sheehy steven-sheehy added this to the Mirror 0.4.1 milestone Nov 26, 2019
@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #402 into master will decrease coverage by 0.02%.
The diff coverage is 52.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   57.67%   57.65%   -0.03%     
==========================================
  Files          56       56              
  Lines        2474     2477       +3     
  Branches      323      323              
==========================================
+ Hits         1427     1428       +1     
- Misses        900      902       +2     
  Partials      147      147
Impacted Files Coverage Δ
.../com/hedera/mirror/importer/domain/EntityType.java 33.33% <ø> (ø)
.../com/hedera/mirror/importer/domain/StreamType.java 100% <ø> (ø)
.../downloader/balance/AccountBalancesDownloader.java 80% <ø> (ø)
...com/hedera/mirror/importer/domain/Transaction.java 86.66% <ø> (ø)
...com/hedera/mirror/importer/parser/FileWatcher.java 14.7% <ø> (ø)
...hedera/mirror/importer/domain/TransactionType.java 33.33% <ø> (ø)
.../hedera/mirror/importer/domain/CryptoTransfer.java 80% <ø> (ø)
...er/downloader/event/EventStreamFileDownloader.java 33.33% <ø> (ø)
...a/mirror/importer/parser/balance/NumberedLine.java 75% <ø> (ø)
.../hedera/mirror/importer/MirrorNodeApplication.java 33.33% <ø> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494d08a...a30eadd. Read the comment docs.

@mike-burrage-hedera mike-burrage-hedera merged commit 27f62c2 into master Nov 26, 2019
@mike-burrage-hedera mike-burrage-hedera deleted the importer-package branch November 26, 2019 04:37
@apeksharma
Copy link
Contributor

why does this have so many non-import related changes - mainly removal of 'final' keyword?

@steven-sheehy
Copy link
Member Author

I have the save actions plugin installed in Intellij (you should too) and it automatically formatted the code when updating the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P1 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants