Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename com.hedera.mirror to com.hedera.mirror.importer #401

Closed
wants to merge 1 commit into from

Conversation

apeksharma
Copy link
Contributor

@apeksharma apeksharma commented Nov 23, 2019

Signed-off-by: Apekshit Sharma apekshit.sharma@hedera.com

Detailed description:
Reference: #400 (comment)
It's just intellij rename, no manual changes were done.

Which issue(s) this PR fixes:
Fixes #359

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #401 into multimodule will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             multimodule     #401   +/-   ##
==============================================
  Coverage          57.67%   57.67%           
  Complexity           441      441           
==============================================
  Files                 56       56           
  Lines               2474     2474           
  Branches             323      323           
==============================================
  Hits                1427     1427           
  Misses               900      900           
  Partials             147      147
Impacted Files Coverage Δ Complexity Δ
...er/downloader/event/EventStreamFileDownloader.java 33.33% <ø> (ø) 2 <0> (?)
...a/com/hedera/mirror/importer/MirrorProperties.java 92.85% <ø> (ø) 7 <0> (?)
...va/com/hedera/mirror/importer/domain/FileData.java 66.66% <ø> (ø) 2 <0> (?)
.../com/hedera/mirror/importer/domain/RecordFile.java 57.14% <ø> (ø) 4 <0> (?)
...or/importer/exception/InvalidDatasetException.java 0% <ø> (ø) 0 <0> (?)
...era/mirror/importer/config/CacheConfiguration.java 100% <ø> (ø) 2 <0> (?)
...va/com/hedera/mirror/importer/domain/LiveHash.java 66.66% <ø> (ø) 2 <0> (?)
.../com/hedera/mirror/importer/domain/StreamType.java 100% <ø> (ø) 6 <0> (?)
...dera/mirror/importer/domain/ApplicationStatus.java 25% <ø> (ø) 1 <0> (?)
.../com/hedera/mirror/importer/domain/EntityType.java 33.33% <ø> (ø) 1 <0> (?)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7f0544...2757395. Read the comment docs.

Signed-off-by: Apekshit Sharma <apekshit.sharma@hedera.com>
@steven-sheehy
Copy link
Member

I can take this over. But adding a note that we should change the configuration properties as well to add importer to the importer specific properties in this PR. Or in a separate PR.

@apeksharma
Copy link
Contributor Author

I can take this over. But adding a note that we should change the configuration properties as well to add importer to the importer specific properties in this PR. Or in a separate PR.

Cool, go for it.
I had same plan: package rename -> unblock other stuff -> properties' changes
It might be easier to do a new PR though rather than rebasing this one. Up to you.

@steven-sheehy
Copy link
Member

Superceded by #402

@steven-sheehy steven-sheehy deleted the package_rename branch December 12, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants