Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCS fix deploy script and service files. Update version to 0.1.0-rc1 #446

Merged
merged 1 commit into from
Dec 13, 2019
Merged

HCS fix deploy script and service files. Update version to 0.1.0-rc1 #446

merged 1 commit into from
Dec 13, 2019

Conversation

mike-burrage-hedera
Copy link
Contributor

@mike-burrage-hedera mike-burrage-hedera commented Dec 12, 2019 •
edited
Loading

Detailed description:

  • Update versions from 0.1.0-SNAPSHOT to 0.1.0-rc1
  • Make service name match artifact (-hcs suffix)
  • Adjust deploy script for new service name.
  • Fix bug in deploy script introduced in Maven multi module #359 #400. jar name is "-0.1.0", directory is "-v0.1.0". Links at the end of deploy script fail.
  • Change to CircleCI - version tags for HCS will be hcs/v0.1.0 style.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@mike-burrage-hedera mike-burrage-hedera added hcs Hedera Consensus Service P1 labels Dec 12, 2019
@mike-burrage-hedera mike-burrage-hedera added this to the HCS 0.1 milestone Dec 12, 2019
@mike-burrage-hedera mike-burrage-hedera changed the title HCS fix deploy script and service files. Update version to 0.1.0-rc1 WIP: HCS fix deploy script and service files. Update version to 0.1.0-rc1 Dec 12, 2019
@steven-sheehy steven-sheehy added the bug Type: Something isn't working label Dec 12, 2019
apeksharma
apeksharma previously approved these changes Dec 12, 2019
View reviewed changes
hedera-mirror-importer/scripts/deploy.sh Show resolved Hide resolved
@mike-burrage-hedera mike-burrage-hedera changed the title WIP: HCS fix deploy script and service files. Update version to 0.1.0-rc1 HCS fix deploy script and service files. Update version to 0.1.0-rc1 Dec 12, 2019
Nana-EC
Nana-EC previously approved these changes Dec 13, 2019
View reviewed changes
@mike-burrage-hedera
Fix HCS deploy scripts and related service files. Update version to 0…
069f528 
….1.0-rc1.

Keep service names the same on hcs as master.

Signed-off-by: Mike Burrage <mike.burrage@hedera.com>
@mike-burrage-hedera mike-burrage-hedera changed the base branch from hcs to master December 13, 2019 17:00
@mike-burrage-hedera mike-burrage-hedera changed the base branch from master to hcs December 13, 2019 17:00
steven-sheehy
steven-sheehy approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit ccaed34 into hcs Dec 13, 2019
@steven-sheehy steven-sheehy deleted the bug/deploy branch December 13, 2019 17:23
steven-sheehy pushed a commit that referenced this pull request Dec 30, 2019
@mike-burrage-hedera @steven-sheehy
Fix HCS deploy scripts and related service files. Update version to 0…
7415b4f 
….1.0-rc1. (#446)

Keep service names the same on hcs as master.

Signed-off-by: Mike Burrage <mike.burrage@hedera.com>
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeksharma apeksharma apeksharma left review comments

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

Assignees
No one assigned
Labels
bug Type: Something isn't working hcs Hedera Consensus Service P1
Projects
None yet
Milestone
HCS 0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mike-burrage-hedera @apeksharma @steven-sheehy @Nana-EC