Maven multi module #359

[apeksharma]

Two modules: mirror-importer and mirror-rest
Updated docs
Update CircleCI
Update deploy script and service name

Tested:

1. ./mvnw package
2. BUCKET=hedera-mainnet-streams docker-compose updocker-compose down

Signed-off-by: Apekshit Sharma apekshit.sharma@hedera.com

Detailed description:
Circle CI run with artifacts: https://app.circleci.com/github/hashgraph/hedera-mirror-node/pipelines/34945256-21fa-4343-be9e-3d80e6700da5/workflows/194047fe-892a-4fc4-a9f9-c22a1edaa6bf

Which issue(s) this PR fixes:
Fixes #359

Special notes for your reviewer:

Checklist

• Documentation added
• Tests updated

[steven-sheehy]

I think we should move all Java source under a importer package to avoid package collisions between maven modules. com.hedera.mirror.importer

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@55fafb1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #400   +/-   ##
=========================================
  Coverage          ?   57.67%           
=========================================
  Files             ?       56           
  Lines             ?     2474           
  Branches          ?      323           
=========================================
  Hits              ?     1427           
  Misses            ?      900           
  Partials          ?      147

Impacted Files	Coverage Δ
...com/hedera/mirror/parser/balance/NumberedLine.java	75% <ø> (ø)
...java/com/hedera/mirror/domain/TransactionType.java	33.33% <ø> (ø)
...ava/com/hedera/mirror/parser/ParserProperties.java	100% <ø> (ø)
...a/com/hedera/mirror/config/CacheConfiguration.java	100% <ø> (ø)
...era/mirror/parser/event/EventStreamFileParser.java	2.58% <ø> (ø)
.../java/com/hedera/mirror/domain/ContractResult.java	83.33% <ø> (ø)
...c/main/java/com/hedera/mirror/domain/FileData.java	66.66% <ø> (ø)
...c/main/java/com/hedera/mirror/domain/LiveHash.java	66.66% <ø> (ø)
...edera/mirror/parser/balance/BalanceFileParser.java	7.14% <ø> (ø)
...era/mirror/parser/event/EventParserProperties.java	85.71% <ø> (ø)
... and 46 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55fafb1...c0660c0. Read the comment docs.

[apeksharma]

I think we should move all Java source under a importer package to avoid package collisions between maven modules. com.hedera.mirror.importer

Sounds good. Will also make it easy to see spot inter module dependency from import list.
(update1) Since the current PR is much easier to review with all the java files folded, i'd prefer doing package renaming as separate PR for easier review.
(update2) Here's the PR: #401

[steven-sheehy]

Looking better. Let's update the docker-compose.yml to change the names and paths (mirror-db, mirror-rest, mirror-importer, /var/lib/mirror-importer). Also change the docker image names as well.

[apeksharma]

Just couple minor comments above. Looks great otherwise.

[apeksharma]

i just realized that my last change removing blank lines and this plugin didn't get checked in. Sorry about that.
Can you please remove this too. Thanks.

[apeksharma]

looks good. let's get it in.
Let's push a test tag to check the artifacts too, wdyt?
btw, you'll have to approve it :)