Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of HCS missing messages #508

Merged
merged 1 commit into from Jan 24, 2020
Merged

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Change missing message logic from flatMapSequential() to concatMap() since former would run inner flux concurrently then order at the end, causing race conditions with state of TopicContext
  • Moved missing messages to top level so it could take advantage of the filtering for duplicates. This helped in dev when sequence numbers and timestamps didn't match or were duplicated
  • Re-wrote the missing message test to be more accurate using mocks
  • Change CircleCI Maven logging to not show download transfer progress
  • Bump version of Maven and Maven Wrapper

Which issue(s) this PR fixes:
Fixes #505

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 grpc Area: GRPC API labels Jan 24, 2020
@steven-sheehy steven-sheehy added this to the Mirror 0.5.3 milestone Jan 24, 2020
@steven-sheehy steven-sheehy self-assigned this Jan 24, 2020
@steven-sheehy steven-sheehy merged commit e8a01ba into master Jan 24, 2020
@steven-sheehy steven-sheehy deleted the missing-messages branch January 24, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working grpc Area: GRPC API P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe topic queries for invalid missing message sequence
2 participants