Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Mirror network endpoints #720

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

bamzedev
Copy link
Contributor

@bamzedev bamzedev commented Mar 17, 2023

Description:
Updating mirror node endpoints and optimizing readmit times for nodes.

Related issue(s):

Fixes #665, #719

Notes for reviewer:
Its mostly tests, though. There were zero unit tests for this.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@bamzedev bamzedev force-pushed the fix/update-mirror-node-endpoints branch from ee3fcbf to 9721a00 Compare March 17, 2023 15:36
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Signed-off-by: Emanuel Pargov <bamzedev@gmail.com>
@bamzedev bamzedev force-pushed the fix/update-mirror-node-endpoints branch from 7de1234 to 9325a37 Compare March 20, 2023 15:31
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (3613e12) 55.50% compared to head (9325a37) 55.57%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #720      +/-   ##
===========================================
+ Coverage    55.50%   55.57%   +0.06%     
===========================================
  Files          162      162              
  Lines        32726    32730       +4     
===========================================
+ Hits         18166    18189      +23     
+ Misses       13282    13270      -12     
+ Partials      1278     1271       -7     
Impacted Files Coverage Δ
client.go 59.09% <ø> (-0.13%) ⬇️
mirror_network.go 76.00% <ø> (-8.62%) ⬇️
managed_network.go 100.00% <100.00%> (+20.90%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Mar 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bamzedev bamzedev merged commit d9fbbf9 into develop Mar 20, 2023
@bamzedev bamzedev deleted the fix/update-mirror-node-endpoints branch March 20, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mirror node endpoints
2 participants