Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContractDeleteSuite.cannotUseMoreThanChildContractLimit #8994

Closed
vtronkov opened this issue Oct 3, 2023 · 0 comments · Fixed by #9707
Closed

Fix ContractDeleteSuite.cannotUseMoreThanChildContractLimit #8994

vtronkov opened this issue Oct 3, 2023 · 0 comments · Fixed by #9707
Assignees
Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization

Comments

@vtronkov
Copy link
Contributor

vtronkov commented Oct 3, 2023

In #8911 we are adding validation where we throw an error when there are more child records than allowed(MAX_CHILD_RECORDS_EXCEEDED) - so part of the test is passing.

Now the part we are verifying the child record count is failing(getTxnRecord(precompileViolation)).
The problem is that we are not creating records for each internal contract call.

For this issue, we need to create a record for each internal contract call and add it to the cache.

@vtronkov vtronkov added the Modularization Issues or PRs related to modularization label Oct 3, 2023
@Petyo-Lukanov Petyo-Lukanov added the Limechain Work planned for the LimeChain team label Oct 3, 2023
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants