Fix cannotUseMoreThanChildContractLimit test #9707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
# Conflicts: # hedera-node/hedera-smart-contract-service-impl/src/main/java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/hts/AbstractNonRevertibleTokenViewCall.java
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
MiroslavGatsanoga
requested review from
a team and
tinker-michaelj
as code owners
tinker-michaelj
previously approved these changes
Nov 8, 2023
Base automatically changed from
09357-fix-approve-allowance-tests
to
develop
November 10, 2023 07:03
thenswan
dismissed stale reviews from tinker-michaelj and mustafauzunn
The base branch was changed.
…imit-test Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech>
MiroslavGatsanoga
force-pushed
the
09124-fix-cannotUseMoreThanChildContractLimit-test
branch
from
1dedb9d
to
df9bdd6
Compare
MiroslavGatsanoga
deleted the
09124-fix-cannotUseMoreThanChildContractLimit-test
branch
nickpoorman
pushed a commit
that referenced
this pull request
Nov 22, 2023
Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Nikita Lebedev <nikita.lebedev@limechain.tech> Signed-off-by: Nick Poorman <nick@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Having the child records logic from #9649 we're now can enable this test that checks for
MAX_CHILD_RECORDS_EXCEEDEDcases.Related issue(s):
#9124
Fixes: #8994
Notes for reviewer:
Checklist