fix: LeakyContractTestsSuite HAPI tests #10287

MrValioBg · 2023-12-05T15:13:05Z

Description:

Use ContracCallRecordBuilder instead of CryptoCreateRecordBuilder
Also adds support for multiple priority statuses (implementation provided by a cherry-picked commit authored by @tinker-michaelj).
Don't activate tests that seem to require legacy key verification - comment above them about the behavior.

These changes aim to provide correct logic and fix tests in the LeakyContractTestsSuite.

Related issue(s):

Fixes #9398
#9399
#9397

Notes for reviewer:
Please check the github comments I left in the code.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

github-actions · 2023-12-05T15:30:59Z

Node: HAPI Test (Crypto) Results

211 tests ±0 204 ✔️ ±0 17m 44s ⏱️ +35s
  22 suites ±0     7 💤 ±0
  22 files ±0     0 ❌ ±0

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-05T15:39:41Z

Node: HAPI Test (Token) Results

189 tests ±0 189 ✔️ ±0 16m 49s ⏱️ - 1m 8s
  13 suites ±0     0 💤 ±0
  13 files ±0     0 ❌ ±0

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-05T15:40:00Z

Node: Unit Test Results

    2 293 files ±0     2 293 suites ±0 56m 21s ⏱️ + 1m 12s
118 448 tests +3 118 414 ✔️ +3 34 💤 ±0 0 ❌ ±0
126 865 runs +3 126 831 ✔️ +3 34 💤 ±0 0 ❌ ±0

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

codecov · 2023-12-05T15:41:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50a7d5c) 62.98% compared to head (48c01d6) 63.04%.
Report is 7 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #10287      +/-   ##
=============================================
+ Coverage      62.98%   63.04%   +0.06%     
- Complexity     30813    30835      +22     
=============================================
  Files           3363     3363              
  Lines         135415   135487      +72     
  Branches       14090    14096       +6     
=============================================
+ Hits           85287    85416     +129     
+ Misses         46768    46708      -60     
- Partials        3360     3363       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-12-05T15:44:45Z

Node: HAPI Test (Time Consuming) Results

21 tests ±0   9 ✔️ ±0 24m 41s ⏱️ -11s
  2 suites ±0 12 💤 ±0
  2 files ±0   0 ❌ ±0

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-05T15:46:35Z

Node: HAPI Test (Misc) Results

420 tests ±0 333 ✔️ +4 30m 53s ⏱️ + 1m 59s
  74 suites ±0   87 💤 - 4
  74 files ±0     0 ❌ ±0

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-05T15:48:08Z

Node: Integration Test Results

278 tests ±0 278 ✔️ ±0 26m 54s ⏱️ +9s
    5 suites ±0     0 💤 ±0
    5 files ±0     0 ❌ ±0

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

github-actions · 2023-12-05T15:50:01Z

Node: E2E Test Results

    1 files ±    0     1 suites ±0 24m 57s ⏱️ + 24m 57s
311 tests +310 311 ✔️ +311 0 💤 ±0 0 ❌ - 1
333 runs +332 333 ✔️ +333 0 💤 ±0 0 ❌ - 1

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.

EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

github-actions · 2023-12-05T16:08:23Z

Node: HAPI Test (Smart Contract) Results

399 tests +1 373 ✔️ +8 45m 58s ⏱️ + 1m 17s
  55 suites ±0   26 💤 - 6
  55 files ±0     0 ❌ - 1

Results for commit 48c01d6. ± Comparison against base commit 50a7d5c.

♻️ This comment has been updated with latest results.

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

.../hedera/node/app/service/contract/impl/exec/systemcontracts/hts/create/CreateTranslator.java

...test-clients/src/main/java/com/hedera/services/bdd/suites/leaky/LeakyContractTestsSuite.java

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

tinker-michaelj

We should just add a comment to any HapiSpec that expects to be able to use top-level signatures like,

// Requires legacy security model, cannot be enabled as @HapiTest without refactoring to use contract keys

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/leaky/LeakyContractTestsSuite.java

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

tinker-michaelj

LGTM, ty @MrValioBg !

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

tinker-michaelj

LGTM!

mustafauzunn

LGTM

init: initial fixes for verification and child records for crypto create

bff06ed

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

MrValioBg changed the title ~~fix: LeakyContractTestsSuite fees related tests~~ fix: LeakyContractTestsSuite tests related to fees Dec 5, 2023

MrValioBg self-assigned this Dec 5, 2023

MrValioBg added the Limechain Work planned for the LimeChain team label Dec 5, 2023

MrValioBg linked an issue Dec 5, 2023 that may be closed by this pull request

Fix createTokenWithInvalidRoyaltyFee test #9399

Closed

MrValioBg added 5 commits December 6, 2023 15:20

test: fix unit tests

2b8b0fb

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

refactor: remove useless if case

1b517e2

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

refactor: wrap bytes of protoName instead of ordinal

5deadf7

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

refactor: add unit tests for logic, optimize code & docs

c8fc71c

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

chore: add docs

14399c1

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

MrValioBg commented Dec 11, 2023

View reviewed changes

.../hedera/node/app/service/contract/impl/exec/systemcontracts/hts/create/CreateTranslator.java Outdated Show resolved Hide resolved

MrValioBg commented Dec 11, 2023

View reviewed changes

...test-clients/src/main/java/com/hedera/services/bdd/suites/leaky/LeakyContractTestsSuite.java Outdated Show resolved Hide resolved

MrValioBg requested a review from netopyr December 11, 2023 13:56

MrValioBg added 2 commits December 11, 2023 16:00

refactor: remove useless changes

2064f4f

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

chore: format

2dd8b2d

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

MrValioBg marked this pull request as ready for review December 11, 2023 14:23

MrValioBg requested review from a team and tinker-michaelj as code owners December 11, 2023 14:23

MrValioBg requested a review from quiet-node December 11, 2023 14:23

tinker-michaelj requested changes Dec 11, 2023

View reviewed changes

refactor: remove legacy security model logic

f4e87c7

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

MrValioBg requested a review from tinker-michaelj December 13, 2023 07:11

stoyanov-st mentioned this pull request Dec 13, 2023

fix: LeakyContractTestsSuite test with top-level signatures #10486

Merged

2 tasks

Merge branch 'develop' into 08896-fix-fees-related-leaky-tests

9228f5d

# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/leaky/LeakyContractTestsSuite.java

MrValioBg changed the title ~~fix: LeakyContractTestsSuite tests related to fees~~ fix: LeakyContractTestsSuite HAPI tests Dec 18, 2023

MrValioBg and others added 2 commits December 18, 2023 15:38

Merge branch 'develop' into 08896-fix-fees-related-leaky-tests

654c471

Allow multiple expected priority statuses

d0f864d

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>

MrValioBg linked an issue Dec 18, 2023 that may be closed by this pull request

Fix payerCannotOverSendValue test #9397

Closed

MrValioBg added 3 commits December 18, 2023 20:58

refactor: use simpler approach for fixing empty recordbuilder status

f5437bc

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

refactor: remove useless changes

63d85d9

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

refactor: spotless apply

c73e229

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

tinker-michaelj previously approved these changes Dec 18, 2023

View reviewed changes

tests: fix unit tests

48c01d6

Signed-off-by: Valentin Valkanov <valentin.valkanov@limechain.tech>

MrValioBg dismissed tinker-michaelj’s stale review via 48c01d6 December 18, 2023 21:59

MrValioBg requested a review from tinker-michaelj December 18, 2023 22:00

tinker-michaelj approved these changes Dec 18, 2023

View reviewed changes

mustafauzunn approved these changes Dec 19, 2023

View reviewed changes

MrValioBg merged commit 7a58a17 into develop Dec 19, 2023
39 checks passed

MrValioBg deleted the 08896-fix-fees-related-leaky-tests branch December 19, 2023 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: LeakyContractTestsSuite HAPI tests #10287

fix: LeakyContractTestsSuite HAPI tests #10287

MrValioBg commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

codecov bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

tinker-michaelj left a comment

tinker-michaelj left a comment

tinker-michaelj left a comment

mustafauzunn left a comment

fix: LeakyContractTestsSuite HAPI tests #10287

fix: LeakyContractTestsSuite HAPI tests #10287

Conversation

MrValioBg commented Dec 5, 2023 • edited

github-actions bot commented Dec 5, 2023 • edited

Node: HAPI Test (Crypto) Results

github-actions bot commented Dec 5, 2023 • edited

Node: HAPI Test (Token) Results

github-actions bot commented Dec 5, 2023 • edited

Node: Unit Test Results

codecov bot commented Dec 5, 2023 • edited

Codecov Report

github-actions bot commented Dec 5, 2023 • edited

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Dec 5, 2023 • edited

Node: HAPI Test (Misc) Results

github-actions bot commented Dec 5, 2023 • edited

Node: Integration Test Results

github-actions bot commented Dec 5, 2023 • edited

Node: E2E Test Results

github-actions bot commented Dec 5, 2023 • edited

Node: HAPI Test (Smart Contract) Results

tinker-michaelj left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

mustafauzunn left a comment

Choose a reason for hiding this comment

MrValioBg commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

codecov bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited

github-actions bot commented Dec 5, 2023 •

edited