fix: LeakyContractTestsSuite test with top-level signatures
#10486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10486 +/- ##
==========================================
Coverage 63.01% 63.02%
- Complexity 30804 30809 +5
==========================================
Files 3360 3360
Lines 135346 135346
Branches 14088 14088
==========================================
+ Hits 85289 85301 +12
+ Misses 46695 46689 -6
+ Partials 3362 3356 -6 ☔ View full report in Codecov by Sentry. |
tinker-michaelj
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
LGTM, we may want to extract these tests into a separate suite? (@netopyr?)
|
Yes, please move the tests to another class similar to other cases where we had tests depending on the legacy security model. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As per this comment #10287 (review)
The tests requiring top-level signatures are commented
Related issue(s):
Fixes #9392
Notes for reviewer:
Checklist