fix: ensure failed CREATE2 action is finalized w/ proper frame
#10366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
tinker-michaelj
requested review from
JeffreyDallas,
jeromy-cannon,
jasperpotts and
povolev15
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10366 +/- ##
=============================================
- Coverage 63.52% 63.51% -0.01%
- Complexity 30990 31008 +18
=============================================
Files 3341 3342 +1
Lines 134577 134698 +121
Branches 13994 14005 +11
=============================================
+ Hits 85484 85556 +72
- Misses 45736 45783 +47
- Partials 3357 3359 +2 ☔ View full report in Codecov by Sentry. |
Nana-EC
requested review from
shemnon,
stoqnkpL,
lukelee-sl and
david-bakin-sl
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
jeromy-cannon
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CREATE2needstraceAccountCreationResult()tracer hook implemented in mono-service #10360tracePostExecution()is never called upon aCREATE2address collision, re-implementstraceAccountCreationResult()in mono-serviceHederaTracerand updates theMessageCallProcessorsnot to make duplicate calls totracePostExecution().