Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure failed CREATE2 action is finalized w/ proper frame #10367

Merged
merged 3 commits into from Dec 8, 2023

Conversation

tinker-michaelj
Copy link
Collaborator

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
iwsimon
iwsimon previously approved these changes Dec 7, 2023
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Crypto) Results

211 tests   201 ✔️  17m 25s ⏱️
  22 suites    10 💤
  22 files        0

Results for commit b140383.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: Unit Test Results

    2 288 files  ±0      2 288 suites  ±0   47m 22s ⏱️ - 7m 41s
118 399 tests +1  118 365 ✔️ +1  34 💤 ±0  0 ±0 
126 771 runs  +1  126 737 ✔️ +1  34 💤 ±0  0 ±0 

Results for commit b140383. ± Comparison against base commit 2ccffcf.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Token) Results

190 tests   188 ✔️  18m 39s ⏱️
  13 suites      2 💤
  13 files        0

Results for commit b140383.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0a8bd3d) 63.11% compared to head (b140383) 63.12%.
Report is 3 commits behind head on release/0.45.

Files Patch % Lines
...contracts/execution/traceability/HederaTracer.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/0.45   #10367   +/-   ##
===============================================
  Coverage           63.11%   63.12%           
- Complexity          30695    30702    +7     
===============================================
  Files                3332     3332           
  Lines              134003   134007    +4     
  Branches            13886    13886           
===============================================
+ Hits                84577    84592   +15     
+ Misses              46082    46073    -9     
+ Partials             3344     3342    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Misc) Results

419 tests   313 ✔️  25m 19s ⏱️
  73 suites  106 💤
  73 files        0

Results for commit b140383.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  24m 46s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit b140383.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: E2E Test Results

    1 files      1 suites   23m 9s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit b140383.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: Integration Test Results

279 tests   279 ✔️  28m 10s ⏱️
    5 suites      0 💤
    5 files        0

Results for commit b140383.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 7, 2023

Node: HAPI Test (Smart Contract) Results

406 tests   325 ✔️  45m 48s ⏱️
  56 suites    81 💤
  56 files        0

Results for commit d187433.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwsimon iwsimon merged commit 87bff34 into release/0.45 Dec 8, 2023
24 of 26 checks passed
@iwsimon iwsimon deleted the 10360-trace-failed-create2-r45 branch December 8, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants