fix: Add check for empty inline initcode for contract creation #10449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
lukelee-sl
requested review from
thomas-swirlds-labs,
acuarica,
Nana-EC and
david-bakin-sl
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10449 +/- ##
==========================================
Coverage 63.01% 63.02%
- Complexity 30800 30804 +4
==========================================
Files 3360 3360
Lines 135281 135283 +2
Branches 14074 14075 +1
==========================================
+ Hits 85253 85267 +14
+ Misses 46679 46670 -9
+ Partials 3349 3346 -3 ☔ View full report in Codecov by Sentry. |
david-bakin-sl
approved these changes
Dec 12, 2023
.../main/java/com/hedera/node/app/service/mono/txns/contract/ContractCreateTransitionLogic.java
Show resolved
Hide resolved
...pl/src/main/java/com/hedera/node/app/service/contract/impl/infra/HevmTransactionFactory.java
Show resolved
Hide resolved
Neeharika-Sompalli
approved these changes
Dec 13, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a check to ensure that contracts with empty initcode cannot be created. There was a check for checking empty smart contract byte code files but not for inline transactions.
Checklist