Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add check for empty inline initcode for contract creation #10463

Merged
merged 1 commit into from Dec 13, 2023

Conversation

lukelee-sl
Copy link
Member

Description:
Cherry pick #10449

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Copy link

github-actions bot commented Dec 13, 2023

Node: HAPI Test (Crypto) Results

211 tests  ±0   201 ✔️ +57   19m 7s ⏱️ + 2m 28s
  22 suites ±0     10 💤 ±  0 
  22 files   ±0       0  - 57 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

♻️ This comment has been updated with latest results.

Copy link

Node: Unit Test Results

    2 288 files  ±0      2 288 suites  ±0   45m 23s ⏱️ + 6m 23s
118 402 tests +2  118 368 ✔️ +2  34 💤 ±0  0 ±0 
126 774 runs  +2  126 740 ✔️ +2  34 💤 ±0  0 ±0 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

Copy link

Node: HAPI Test (Token) Results

190 tests  ±0   188 ✔️ ±0   18m 12s ⏱️ - 2m 49s
  13 suites ±0       2 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55c0359) 63.11% compared to head (6cd01ba) 63.11%.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/0.45   #10463   +/-   ##
===============================================
  Coverage           63.11%   63.11%           
- Complexity          30698    30702    +4     
===============================================
  Files                3332     3332           
  Lines              134010   134012    +2     
  Branches            13886    13887    +1     
===============================================
+ Hits                84580    84586    +6     
  Misses              46083    46083           
+ Partials             3347     3343    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Misc) Results

419 tests  ±0   313 ✔️ ±0   25m 51s ⏱️ + 1m 5s
  73 suites ±0   106 💤 ±0 
  73 files   ±0       0 ±0 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   24m 52s ⏱️ -45s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 20s ⏱️ + 23m 20s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

Copy link

Node: Integration Test Results

279 tests  ±0   279 ✔️ ±0   28m 29s ⏱️ +2s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

Copy link

Node: HAPI Test (Smart Contract) Results

407 tests  +1   326 ✔️ +1   49m 13s ⏱️ + 6m 59s
  56 suites ±0     81 💤 ±0 
  56 files   ±0       0 ±0 

Results for commit 6cd01ba. ± Comparison against base commit 55c0359.

Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cherry pick LGTM (I reviewed the source PR).

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @lukelee-sl

@iwsimon iwsimon merged commit bd6f48c into release/0.45 Dec 13, 2023
35 of 36 checks passed
@iwsimon iwsimon deleted the cherry-pick-10449 branch December 13, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants