Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 10535 add enum converter #10557

Merged
merged 8 commits into from
Dec 20, 2023
Merged

fix: 10535 add enum converter #10557

merged 8 commits into from
Dec 20, 2023

Commits on Dec 18, 2023

  1. Enum converter 

    Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    62ff28d View commit details
    Browse the repository at this point in the history

  2. Enum converter test 

    Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c9e0b52 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Addressing code review comments, + Converter specific test, + additio… 

    …nal checks on ConfigDataServiceTest

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    0fa8bd0 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Moving conversion tests to EnumConverterTest class, 

    Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    38413fc View commit details
    Browse the repository at this point in the history

  2. Moving conversion tests to EnumConverterTest class, 

    Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b8abea8 View commit details
    Browse the repository at this point in the history

  3. Moving conversion tests to EnumConverterTest class, 

    Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    38e4a4b View commit details
    Browse the repository at this point in the history

  4. Removing unnecessary parametrized test 

    Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ac519e2 View commit details
    Browse the repository at this point in the history

  5. Adding a second value for enum 

    Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
    @mxtartaglia-sl
    mxtartaglia-sl committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    4943758 View commit details
    Browse the repository at this point in the history