fix: 10535 add enum converter #10557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
...-sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/converters/EnumConverter.java
Outdated
Show resolved
Hide resolved
...-sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/converters/EnumConverter.java
Outdated
Show resolved
Hide resolved
...-sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/converters/EnumConverter.java
Outdated
Show resolved
Hide resolved
...sdk/swirlds-config-impl/src/main/java/com/swirlds/config/impl/internal/ConverterService.java
Outdated
Show resolved
Hide resolved
…nal checks on ConfigDataServiceTest Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
|
Sorry for the silly omissions @hendrikebbers , would you please re-review the last commit with the required fixes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10557 +/- ##
==========================================
Coverage ? 63.04%
Complexity ? 30843
==========================================
Files ? 3366
Lines ? 135498
Branches ? 14094
==========================================
Hits ? 85425
Misses ? 46711
Partials ? 3362 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
hendrikebbers
previously approved these changes
Dec 20, 2023
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
hendrikebbers
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Creates a default support for converting enum values
Related issue(s):
Fixes # #10535