Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding enum mention to supported datatypes #10596

Merged
merged 2 commits into from Dec 21, 2023

Conversation

mxtartaglia-sl
Copy link
Contributor

Description:
Small PR that adds Enum as supported datatype
Related issue(s):
Fixes #10535

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>

Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
@mxtartaglia-sl mxtartaglia-sl requested review from a team as code owners December 20, 2023 19:13
@mxtartaglia-sl mxtartaglia-sl changed the title Adding enum mention to supported datatypes fix: adding enum mention to supported datatypes Dec 20, 2023
Copy link

github-actions bot commented Dec 20, 2023

Node: HAPI Test (Crypto) Results

211 tests   205 ✔️  17m 21s ⏱️
  22 suites      6 💤
  22 files        0

Results for commit 7581432.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 20, 2023

Node: HAPI Test (Token) Results

189 tests   189 ✔️  17m 2s ⏱️
  13 suites      0 💤
  13 files        0

Results for commit 7581432.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 20, 2023

Node: Unit Test Results

    2 290 files  ±0      2 290 suites  ±0   52m 0s ⏱️ -45s
118 607 tests ±0  118 573 ✔️ ±0  34 💤 ±0  0 ±0 
127 024 runs  ±0  126 990 ✔️ ±0  34 💤 ±0  0 ±0 

Results for commit 7581432. ± Comparison against base commit 5cbc6f0.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 20, 2023

Node: E2E Test Results

    1 files      1 suites   23m 33s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit 7581432.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@5cbc6f0). Click here to learn what that means.

❗ Current head a140940 differs from pull request most recent head 7581432. Consider uploading reports for the commit 7581432 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             develop   #10596   +/-   ##
==========================================
  Coverage           ?   63.03%           
  Complexity         ?    30867           
==========================================
  Files              ?     3370           
  Lines              ?   135613           
  Branches           ?    14114           
==========================================
  Hits               ?    85483           
  Misses             ?    46754           
  Partials           ?     3376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 20, 2023

Node: HAPI Test (Time Consuming) Results

21 tests     9 ✔️  25m 18s ⏱️
  2 suites  12 💤
  2 files      0

Results for commit 7581432.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 20, 2023

Node: HAPI Test (Misc) Results

420 tests   347 ✔️  28m 11s ⏱️
  73 suites    73 💤
  73 files        0

Results for commit 7581432.

♻️ This comment has been updated with latest results.

Copy link

Node: HAPI Test (Smart Contract) Results

398 tests   374 ✔️  47m 59s ⏱️
  55 suites    24 💤
  55 files        0

Results for commit a140940.

Copy link

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 33s ⏱️ - 1m 51s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ±0 

Results for commit 7581432. ± Comparison against base commit 5cbc6f0.

@mxtartaglia-sl mxtartaglia-sl merged commit f2754b9 into develop Dec 21, 2023
34 checks passed
@mxtartaglia-sl mxtartaglia-sl deleted the 10535_add_documentation branch December 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create enum converter for simple enum types
2 participants