New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adding enum mention to supported datatypes #10596
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com> Signed-off-by: Maxi Tartaglia <maxi@swirldslabs.com>
mxtartaglia-sl
requested review from
poulok,
imalygin,
timo0,
OlegMazurov and
lpetrovic05
and removed request for
timo0,
imalygin,
OlegMazurov and
poulok
December 20, 2023 19:13
mxtartaglia-sl
changed the title
Adding enum mention to supported datatypes
fix: adding enum mention to supported datatypes
Dec 20, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #10596 +/- ##
==========================================
Coverage ? 63.03%
Complexity ? 30867
==========================================
Files ? 3370
Lines ? 135613
Branches ? 14114
==========================================
Hits ? 85483
Misses ? 46754
Partials ? 3376 ☔ View full report in Codecov by Sentry. |
lpetrovic05
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Small PR that adds Enum as supported datatype
Related issue(s):
Fixes #10535