Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create enum converter for simple enum types #10535

Closed
mxtartaglia-sl opened this issue Dec 15, 2023 · 1 comment · Fixed by #10557 or #10596
Closed

Create enum converter for simple enum types #10535

mxtartaglia-sl opened this issue Dec 15, 2023 · 1 comment · Fixed by #10557 or #10596
Assignees
@mxtartaglia-sl
Milestone
v0.46

Comments

@mxtartaglia-sl
Copy link
Contributor

mxtartaglia-sl commented Dec 15, 2023 •
edited
Loading

We need an easy way to convert enums by name and we do not want to create a specific converter for each enum that can just be converted "by-name".

History:
We can use the ConverterService class to convert a value or ask for the converter
This recent change, enabled us to convert a value to an enum based on its name. But introduce an inconsistency between functionalities we would like to address.

Related:
[Original task] (#10411 (comment)_)
[Abstract Converter] (#10321)

Originally posted by @mxtartaglia-sl in #10411 (comment)
@mxtartaglia-sl mxtartaglia-sl added this to the v0.46 milestone Dec 15, 2023
@mxtartaglia-sl mxtartaglia-sl self-assigned this Dec 15, 2023
@mxtartaglia-sl mxtartaglia-sl changed the title Create Enum converter for Simple enum types Create Enum converter for simple enum types Dec 15, 2023
@mxtartaglia-sl mxtartaglia-sl changed the title Create Enum converter for simple enum types Create enum converter for simple enum types Dec 15, 2023
@mxtartaglia-sl mxtartaglia-sl mentioned this issue Dec 18, 2023
Merged
@mxtartaglia-sl mxtartaglia-sl linked a pull request Dec 18, 2023 that will close this issue
fix: 10535 add enum converter #10557
Merged
This was referenced Dec 18, 2023
Closed
Merged
Closed
@hendrikebbers
Copy link
Member

Please add a short documentation about enum usage to https://github.com/hashgraph/hedera-services/blob/develop/platform-sdk/docs/base/configuration/configuration.md#supported-datatypes

@mxtartaglia-sl mxtartaglia-sl mentioned this issue Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxtartaglia-sl mxtartaglia-sl

Labels
None yet
Projects
None yet
Milestone
v0.46
2 participants
@hendrikebbers @mxtartaglia-sl