chore: Misc contract cleanup and fixes

[Neeharika-Sompalli]

Description:

• Closes Cleanup code as suggested in review of #10230 #10599 by refactoring as suggested.
• Adds AbortException to eliminate duplication of computing the effective senderId; now the exception thrown from an aborted processTransaction() call includes the senderId from computeInvolvedParties().
• Since we no longer need to use the feesOnlyUpdater after an abort, this also lets us easily preserve the HAPI fees charged by the workflow by just committing the root updater after an abort.
  • Avoids partial gas charges by refactoring CustomGasCharging to only charge any fee if all fees are payable.
• Removes unreachable try/catch (ResourceExhaustedException) around runToCompletion().
• For mono-service fidelity, allows long-zero addresses to be used in top-level HAPI operations even when the referenced contract has an EVM address outside the long-zero subspace (accomplished via asPriorityId() calls in HevmTransactionFactory).
• Enables last two specs in EthereumSuite.

[github-actions]

Node: HAPI Test (Crypto) Results

211 tests  ±0   205 ✔️ ±0   16m 9s ⏱️ -35s
  22 suites ±0       6 💤 ±0 
  22 files   ±0       0 ❌ ±0 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 16s ⏱️ +46s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Unit Test Results

    2 291 files  ±0      2 291 suites  ±0   54m 17s ⏱️ + 8m 24s
118 616 tests +3  118 581 ✔️ +3  35 💤 ±0  0 ❌ ±0 
127 033 runs  +3  126 998 ✔️ +3  35 💤 ±0  0 ❌ ±0 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

[github-actions]

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   23m 5s ⏱️ + 23m 5s
311 tests +310  311 ✔️ +311  0 💤 ±0  0 ❌  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0 ❌  - 1 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.

EndToEndTests ‑ initializationError

EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateADDRESS_BOOK
EndToEndTests ‑ ADDRESS_BOOK_CONTROLCanUpdateNODE_DETAILS
EndToEndTests ‑ AccountsGetPayerRecordsIfSoConfigured
EndToEndTests ‑ Acct57CanMakeSmallChanges
EndToEndTests ‑ Acct57CantMakeLargeChanges
EndToEndTests ‑ AddingSignaturesToExecutedTxFails
EndToEndTests ‑ AddingSignaturesToExecutedTxFailsWithLongTermEnabled
EndToEndTests ‑ AddingSignaturesToNonExistingTxFails
EndToEndTests ‑ AddingSignaturesToNonExistingTxFailsWithLongTermEnabled
EndToEndTests ‑ AddressAliasIdFuzzing
…

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Time Consuming) Results

21 tests  ±0     9 ✔️ ±0   25m 1s ⏱️ -27s
  2 suites ±0   12 💤 ±0 
  2 files   ±0     0 ❌ ±0 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Misc) Results

420 tests  ±0   347 ✔️ ±0   28m 16s ⏱️ + 1m 45s
  73 suites ±0     73 💤 ±0 
  73 files   ±0       0 ❌ ±0 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Integration Test Results

280 tests  ±0   280 ✔️ ±0   28m 42s ⏱️ +20s
    5 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@1d9aa27). Click here to learn what that means.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #10634   +/-   ##
==========================================
  Coverage           ?   62.81%           
  Complexity         ?    30894           
==========================================
  Files              ?     3376           
  Lines              ?   136345           
  Branches           ?    14207           
==========================================
  Hits               ?    85641           
  Misses             ?    47308           
  Partials           ?     3396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Node: HAPI Test (Smart Contract) Results

412 tests  ±0   399 ✔️ +3   50m 51s ⏱️ + 3m 55s
  55 suites ±0     13 💤  - 2 
  55 files   ±0       0 ❌  - 1 

Results for commit 693ba10. ± Comparison against base commit 0f965a4.

♻️ This comment has been updated with latest results.

[tinker-michaelj]

LGTM