Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: misc contract cleanup and fixes #10633

Closed
wants to merge 5 commits into from

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Dec 22, 2023

Description:

  • Closes Cleanup code as suggested in review of #10230 #10599 by refactoring as suggested.
  • Adds AbortException to eliminate duplication of computing the effective senderId; now the exception thrown from an aborted processTransaction() call includes the senderId from computeInvolvedParties().
  • Since we no longer need to use the feesOnlyUpdater after an abort, this also lets us easily preserve the HAPI fees charged by the workflow by just committing the root updater after an abort.
    • Avoids partial gas charges by refactoring CustomGasCharging to only charge any fee if all fees are payable.
  • Removes unreachable try/catch (ResourceExhaustedException) around runToCompletion().
  • For mono-service fidelity, allows long-zero addresses to be used in top-level HAPI operations even when the referenced contract has an EVM address outside the long-zero subspace (accomplished via asPriorityId() calls in HevmTransactionFactory).
  • Enables last two specs in EthereumSuite.

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Copy link
Collaborator Author

Closed for #10634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup code as suggested in review of #10230
1 participant