test: Create hapi tests for transfer and send operations for system accounts Part 1 #11359

0xivanov · 2024-02-05T15:29:02Z

Description:

Calling operations on system accounts in hedera may differ from ethereum.
We need to add hapi tests for them and check and document the behaviour.

Add tests for transfer and send operations involving the system accounts and ensure that these tests conform to the expected behavior.

Related issue(s):

Fixes #11138

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

…erations-for-system-accounts

github-actions · 2024-02-05T15:45:01Z

Node: HAPI Test (Restart) Results

1 tests 1 ✔️ 5m 18s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-05T15:47:56Z

Node: HAPI Test (Node Death Reconnect) Results

1 tests 1 ✔️ 7m 45s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-05T16:00:17Z

Node: HAPI Test (Token) Results

189 tests 189 ✔️ 18m 45s ⏱️
  13 suites     0 💤
  13 files     0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-05T16:03:42Z

Node: E2E Test Results

    1 files     1 suites 24m 26s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-05T16:07:26Z

Node: HAPI Test (Crypto) Results

213 tests 213 ✔️ 25m 41s ⏱️
  22 suites     0 💤
  22 files     0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-05T16:14:54Z

Node: Unit Test Results

    2 285 files ±0     2 285 suites ±0 2h 24m 12s ⏱️ - 2h 12m 17s
118 514 tests +1 118 460 ✔️ +2 54 💤 ±0 0 ❌ - 1
127 031 runs +1 126 977 ✔️ +2 54 💤 ±0 0 ❌ - 1

Results for commit 700e7f3. ± Comparison against base commit 77d207f.

♻️ This comment has been updated with latest results.

codecov · 2024-02-05T16:16:08Z

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (8bda7b2) 62.99% compared to head (1669a7b) 62.97%.
Report is 4 commits behind head on develop.

❗ Current head 1669a7b differs from pull request most recent head 1726ca2. Consider uploading reports for the commit 1726ca2 to get more accurate results

Files	Patch %	Lines
...va/com/swirlds/platform/state/iss/IssDetector.java	1.85%	53 Missing ⚠️
...ain/java/com/swirlds/platform/SwirldsPlatform.java	0.00%	34 Missing ⚠️
...atform/state/iss/internal/ConsensusHashFinder.java	0.00%	6 Missing ⚠️
...ava/com/swirlds/platform/state/iss/IssHandler.java	0.00%	5 Missing ⚠️
...transaction/system/SystemTransactionExtractor.java	0.00%	3 Missing ⚠️
...latform/state/iss/internal/RoundHashValidator.java	0.00%	3 Missing ⚠️
...rm/system/state/notifications/IssNotification.java	0.00%	2 Missing ⚠️
...main/java/com/swirlds/platform/wiring/NoInput.java	0.00%	2 Missing ⚠️
...ts/precompile/ExchangeRatePrecompiledContract.java	0.00%	0 Missing and 1 partial ⚠️
...acts/precompile/PrngSystemPrecompiledContract.java	0.00%	0 Missing and 1 partial ⚠️
... and 4 more

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11359      +/-   ##
=============================================
- Coverage      62.99%   62.97%   -0.02%     
+ Complexity     31082    31080       -2     
=============================================
  Files           3362     3363       +1     
  Lines         137674   137695      +21     
  Branches       14479    14480       +1     
=============================================
- Hits           86728    86719       -9     
- Misses         47248    47276      +28     
- Partials        3698     3700       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-02-05T16:22:23Z

Node: HAPI Test (Misc) Results

430 tests 416 ✔️ 47m 49s ⏱️
  74 suites   14 💤
  74 files     0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-05T16:35:27Z

Node: HAPI Test (Time Consuming) Results

20 tests 20 ✔️ 54m 1s ⏱️
  2 suites   0 💤
  2 files   0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

stoqnkpL

Is there a reason .bitLength() was used instead of something like .size()?
Are you sure a bitLength of 4 is enough to cover 4 bytes?

github-actions · 2024-02-05T16:43:09Z

Node: HAPI Test (Smart Contract) Results

451 tests 448 ✔️ 1h 6m 28s ⏱️
  52 suites     3 💤
  52 files     0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-05T16:48:35Z

Node: Integration Test Results

    5 files     5 suites 1h 6m 46s ⏱️
319 tests 319 ✔️ 0 💤 0 ❌
331 runs 331 ✔️ 0 💤 0 ❌

Results for commit 700e7f3.

♻️ This comment has been updated with latest results.

0xivanov · 2024-02-05T16:56:33Z

Is there a reason .bitLength() was used instead of something like .size()? Are you sure a bitLength of 4 is enough to cover 4 bytes?

You are right, bitLength is the bits, so it should be 32 bits or .size() >= 4 which is in bytes.

...m/hedera/node/app/service/contract/impl/exec/systemcontracts/ExchangeRateSystemContract.java

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

tinker-michaelj

We should use the PrecompileContractResult API to communicate results from our PrecompileContracts to our MessageCallProcessor; throwing an InvalidTransactionException increases the API surface with no benefit.

...hedera/node/app/service/mono/store/contracts/precompile/ExchangeRatePrecompiledContract.java

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

codecov-commenter · 2024-02-06T08:45:23Z

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3cf9f8c) 63.03% compared to head (d6b199c) 62.95%.
Report is 11 commits behind head on develop.

Files	Patch %	Lines
...e/contracts/precompile/HTSPrecompiledContract.java	0.00%	1 Missing and 1 partial ⚠️
...acts/precompile/PrngSystemPrecompiledContract.java	0.00%	0 Missing and 1 partial ⚠️
.../impl/exec/systemcontracts/PrngSystemContract.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11359      +/-   ##
=============================================
- Coverage      63.03%   62.95%   -0.08%     
- Complexity     31062    31079      +17     
=============================================
  Files           3367     3369       +2     
  Lines         137592   137799     +207     
  Branches       14457    14465       +8     
=============================================
+ Hits           86727    86748      +21     
- Misses         47171    47351     +180     
- Partials        3694     3700       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

tinker-michaelj

LGTM, ty @0xivanov !

...java/com/hedera/node/app/service/mono/store/contracts/precompile/HTSPrecompiledContract.java

lukelee-sl

General question about the checks for 4 bytes that you added in the system contracts - were they necessary to implement the main point of this pr - that is to show that transfers to system contracts would fail. Or were they added on as an additional check because it was something you noticed while doing the primary task?

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

lukelee-sl

LGTM

Neeharika-Sompalli

LGTM !

tinker-michaelj

LGTM, ty @0xivanov !

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

0xivanov · 2024-02-08T14:20:21Z

All CI checks should be fixed now.

tinker-michaelj

LGTM, ty @0xivanov !

…ccounts Part 1 (#11359) Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

@tag

commit fd7b0fa Author: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Date: Fri Feb 16 07:18:48 2024 +0200 fix: conditional records hollow account creation via internal transfer with max child records exceeded (#10631) Signed-off-by: Miroslav Gatsanoga <miroslav.gatsanoga@limechain.tech> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> commit 0bc20e0 Author: Lev Povolotsky <16233475+povolev15@users.noreply.github.com> Date: Thu Feb 15 23:17:09 2024 -0500 fix: fee charge token create tx and also transaction hashing (#11562) Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> commit de8023b Author: Petar Tonev <petar.tonev@limechain.tech> Date: Thu Feb 15 22:41:18 2024 +0200 fix: add legacy etx support before EIP155 (#11504) commit 6182387 Author: Nikita Lebedev <nikita.lebedev@limechain.tech> Date: Thu Feb 15 22:27:01 2024 +0200 test: add `revertedAutoCreationRollsBackEvenIfTopLevelSucceeds` to `LazyCreateThroughPrecompileSuite` and enable fuzzy-matching on it (#11131) Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech> commit 256e6a1 Author: Nathan Klick <nathan@swirldslabs.com> Date: Thu Feb 15 14:11:29 2024 -0600 build: add new Gradle modules for the block node (#11552) Signed-off-by: Nathan Klick <nathan@swirldslabs.com> commit b18e0da Author: Cody Littley <56973212+cody-littley@users.noreply.github.com> Date: Thu Feb 15 12:29:49 2024 -0600 fix: make verifyAsync() a passthrough method to the executor service (#11547) Signed-off-by: Cody Littley <cody@swirldslabs.com> commit c810e12 Author: Cody Littley <56973212+cody-littley@users.noreply.github.com> Date: Thu Feb 15 11:32:54 2024 -0600 fix: reduce sync permit count (#11545) Signed-off-by: Cody Littley <cody@swirldslabs.com> commit 879abb7 Author: Maxi Tartaglia <152629744+mxtartaglia-sl@users.noreply.github.com> Date: Thu Feb 15 14:08:12 2024 -0300 fix: 11540-ConcurrentTestSupportTest (#11541) Signed-off-by: mxtartaglia <maxi@swirldslabs.com> commit 2281cde Author: Ivo Yankov <ivo@devlabs.bg> Date: Thu Feb 15 17:34:11 2024 +0200 fix: Nonce Discrepancies in Modularization (#11074) Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: nikolay <n.atanasow94@gmail.com> commit 22b662b Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Thu Feb 15 10:29:48 2024 -0500 feat: Create new status panel, and add to existing dashboards (#11533) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit b7cd09e Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Thu Feb 15 10:14:29 2024 -0500 chore: remove event observer dispatcher (#11449) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit 5eeec8f Author: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com> Date: Thu Feb 15 09:09:08 2024 -0600 refactor: return AddressBook from AddressBookRoster (#11511) Signed-off-by: Edward Wertz <edward@swirldslabs.com> commit d11925b Author: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> Date: Thu Feb 15 17:07:04 2024 +0200 fix: Enable fuzzy matching for HRCPrecompileSuite (#11032) Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech> commit 34bdf1f Author: Maxi Tartaglia <152629744+mxtartaglia-sl@users.noreply.github.com> Date: Thu Feb 15 11:15:18 2024 -0300 chore: Add NotNull/Nullable annotations to Metrics module (#11532) Signed-off-by: mxtartaglia <maxi@swirldslabs.com> commit 601f92b Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Wed Feb 14 16:06:23 2024 -0500 feat: use ordered soldering for PCES flush requests (#11451) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit 4ae42e0 Author: Ivo Yankov <ivo@devlabs.bg> Date: Wed Feb 14 22:23:38 2024 +0200 fix: Enable fuzzy matching for ApproveAllowanceSuite (#10787) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> commit 4b9e356 Author: Ivan Malygin <ivan@swirldslabs.com> Date: Wed Feb 14 14:00:42 2024 -0500 fix: 11507 Temporary disabled a test (#11517) Reviewed-by: Anthony Petrov <anthony@swirldslabs.com>, Artem Ananev <artem.ananev@swirldslabs.com> Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> commit 1df51ea Author: Hendrik Ebbers <hendrik.ebbers@web.de> Date: Wed Feb 14 17:39:34 2024 +0100 fix: Improvements for ConcurrentTestSupport (#11276) Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de> Co-authored-by: Maxi Tartaglia <152629744+mxtartaglia-sl@users.noreply.github.com> commit d0efd42 Author: Valentin Tronkov <valentin.tronkov@limechain.tech> Date: Wed Feb 14 18:14:58 2024 +0200 feat: Enhance storage (file) store dumper to handle modular representation (#11385) Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> commit 19cb54b Author: Lev Povolotsky <16233475+povolev15@users.noreply.github.com> Date: Wed Feb 14 11:03:36 2024 -0500 fix: rbs calculation in modularize code (#11518) Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> commit edfbdc1 Author: Matt Hess <matt.hess@swirldslabs.com> Date: Wed Feb 14 10:02:20 2024 -0600 fix: 11320: Use num sigs instead of num keys in token mint fee (#11464) Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> commit 17a0bc2 Author: Michael Tinker <michael.tinker@swirldslabs.com> Date: Tue Feb 13 20:37:34 2024 -0600 chore: remove files with long names (#11512) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> commit 4262396 Author: Iris Simon <122310714+iwsimon@users.noreply.github.com> Date: Tue Feb 13 21:03:45 2024 -0500 fix: fixed IndexOutOfBoundsException (#11493) Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> commit abb0a56 Author: Michael Tinker <michael.tinker@swirldslabs.com> Date: Tue Feb 13 17:27:51 2024 -0600 chore: fix yahcli build, `activate-staking` bug (#11501) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> commit 9902d20 Author: anthony-swirldslabs <152534762+anthony-swirldslabs@users.noreply.github.com> Date: Tue Feb 13 14:17:13 2024 -0800 feat: 11347: introduce ReconnectHalfMillionNodesBench (#11487) Signed-off-by: Anthony Petrov <anthony@swirldslabs.com> commit b19fdaf Author: Ivan Malygin <ivan@swirldslabs.com> Date: Tue Feb 13 17:05:40 2024 -0500 fix: 11507 Temporary disabled tests to stabilize pipeline (#11509) Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> commit bede9b5 Author: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com> Date: Tue Feb 13 15:58:25 2024 -0600 refactor: EventCreator compatible with AncientMode (#11499) Signed-off-by: Edward Wertz <edward@swirldslabs.com> commit f3de036 Author: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com> Date: Tue Feb 13 14:13:33 2024 -0600 feat: Address stores X509Certificate (#11318) Signed-off-by: Edward Wertz <edward@swirldslabs.com> commit 0b4aa8d Author: Deyan Dimitrov <dikelito@tutamail.com> Date: Tue Feb 13 21:42:58 2024 +0200 feat: scheduled txs mono signed state dumper (#11390) Signed-off-by: dikel <dikelito@tutamail.com> commit 9f3bc0e Author: Matt Hess <matt.hess@swirldslabs.com> Date: Tue Feb 13 13:34:16 2024 -0600 fix: Migration only sets node ID under specific condition (#11485) Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> Co-authored-by: Ivan Malygin <ivan@swirldslabs.com> commit 754250c Author: Petar Tonev <petar.tonev@limechain.tech> Date: Tue Feb 13 21:28:53 2024 +0200 fix: check throttle usage on committing changes (#11064) commit e0eef7e Author: Michael Tinker <michael.tinker@swirldslabs.com> Date: Tue Feb 13 11:03:43 2024 -0600 chore: use shorter contract names (#11491) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Michael Heinrichs <netopyr@users.noreply.github.com> commit ac755d1 Author: Lazar Petrovic <lpetrovic05@gmail.com> Date: Tue Feb 13 14:35:57 2024 +0100 fix: state sent to be saved twice (#11488) Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> commit 30e929d Author: Jendrik Johannes <jendrik.johannes@gmail.com> Date: Tue Feb 13 10:40:13 2024 +0100 build: Gradle update and QoL improvements (#11443) Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> commit b74cab4 Author: Jendrik Johannes <jendrik.johannes@gmail.com> Date: Tue Feb 13 10:38:49 2024 +0100 build: add back '-XX:ActiveProcessorCount=6' to 'eet' (#11483) Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> commit 1871c0c Author: Ivan Malygin <ivan@swirldslabs.com> Date: Mon Feb 12 20:36:25 2024 -0500 fix: 11496 Temporary disabled `VirtualPipelineTests.flushThrottle` (#11497) Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> commit 6ea8984 Author: Ivan Ivanov <ivanivanov.ii726@gmail.com> Date: Mon Feb 12 16:07:38 2024 +0200 test: 11134 - Create hapi tests for extCode operations for system accounts (#11278) Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com> commit 02382b6 Author: Ivo Yankov <ivo@devlabs.bg> Date: Mon Feb 12 16:06:11 2024 +0200 fix: Enable tests from Issue2319Spec (#10975) Signed-off-by: Ivo Yankov <ivo@devlabs.bg> commit bb0357b Author: Lazar Petrovic <lpetrovic05@gmail.com> Date: Mon Feb 12 11:56:31 2024 +0100 chore: add debug info (#11473) Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> commit 98d1e45 Author: Cody Littley <56973212+cody-littley@users.noreply.github.com> Date: Fri Feb 9 14:20:32 2024 -0600 fix: revert gossip birth round refactor (#11482) commit 3892609 Author: Ivan Malygin <ivan@swirldslabs.com> Date: Fri Feb 9 14:11:29 2024 -0500 fix: 11472 Added @tag(TIMING_SENSITIVE) to the tests to stabilize the test pipeline. (#11475) Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> commit 00d855a Author: Cody Littley <56973212+cody-littley@users.noreply.github.com> Date: Fri Feb 9 11:35:20 2024 -0600 fix: mark scheduler tests as timing sensitive (#11470) Signed-off-by: Cody Littley <cody@swirldslabs.com> Signed-off-by: Kelly Greco <kelly@swirldslabs.com> Co-authored-by: Kelly Greco <kelly@swirldslabs.com> commit 08a23eb Author: Nikita Lebedev <nikita.lebedev@limechain.tech> Date: Fri Feb 9 19:18:27 2024 +0200 feat: Integrate Validations in HAPI tests (#10944) Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech> Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Matt Hess <matt.hess@swirldslabs.com> Co-authored-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Co-authored-by: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com> commit 3d27455 Author: Jendrik Johannes <jendrik.johannes@gmail.com> Date: Fri Feb 9 17:39:58 2024 +0100 build: re-enable running timing sensitive tests on CI (#11444) Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com> Co-authored-by: Kelly Greco <82919061+poulok@users.noreply.github.com> commit 4f2e467 Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Fri Feb 9 11:02:38 2024 -0500 fix: Increase wait for squelch test assertion (#11461) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit ff4819a Author: Michael Tinker <michael.tinker@swirldslabs.com> Date: Fri Feb 9 09:56:48 2024 -0600 chore: migrate per node pending rewards (#11381) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> commit f373ecb Author: Lazar Petrovic <lpetrovic05@gmail.com> Date: Fri Feb 9 14:20:15 2024 +0100 fix: SignedStateFileManagerTests (#11468) Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> commit 9b8f850 Author: Iris Simon <122310714+iwsimon@users.noreply.github.com> Date: Fri Feb 9 08:11:48 2024 -0500 fix: fixed diff test, ContractCall has status: CONSENSUS_GAS_EXHAUSTED (#11457) Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> commit 3b85b7e Author: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com> Date: Thu Feb 8 15:58:31 2024 -0600 refactor: EventSignatureValidator uses AncientMode (#11433) Signed-off-by: Edward Wertz <edward@swirldslabs.com> commit ff59055 Author: Michael Heinrichs <netopyr@users.noreply.github.com> Date: Thu Feb 8 21:57:13 2024 +0100 fix: Fix service names for metrics (#11456) Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com> commit 119fe64 Author: Cody Littley <56973212+cody-littley@users.noreply.github.com> Date: Thu Feb 8 13:41:21 2024 -0600 refactor: gossip birth round (#11149) Signed-off-by: Cody Littley <cody@swirldslabs.com> commit 8e6fc86 Author: artemananiev <33361937+artemananiev@users.noreply.github.com> Date: Thu Feb 8 10:43:30 2024 -0800 fix: 11298: VirtualMapReconnectTest fails intermittently with path not in range log message (#11435) Reviewed-by: Anthony Petrov <anthony@swirldslabs.com>, Ivan Malygin <ivan@swirldslabs.com> Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com> commit 2372290 Author: Nikolay Atanasow <n.atanasow94@gmail.com> Date: Thu Feb 8 19:18:51 2024 +0200 fix: static call with selfdestruct to system account between 0.0.751 and 0.0.999 results in FAIL_INVALID (#11243) Signed-off-by: nikolay <n.atanasow94@gmail.com> commit b5080b9 Author: Nikita Lebedev <nikita.lebedev@limechain.tech> Date: Thu Feb 8 19:18:27 2024 +0200 fix: contracts.evm.allowCallsToNonContractAccounts flag misbehaviour (#11244) Signed-off-by: Nikita Lebedev <nikita.lebedev@limechain.tech> commit cd5c2b7 Author: Ivan Malygin <ivan@swirldslabs.com> Date: Thu Feb 8 12:14:45 2024 -0500 fix: 11328 Optimized `DataFileReaderPbj.leaseFileChannel` method (#11331) Signed-off-by: Ivan Malygin <ivan@swirldslabs.com> commit acaa4a1 Author: Ivan Ivanov <ivanivanov.ii726@gmail.com> Date: Thu Feb 8 19:08:30 2024 +0200 test: Create hapi tests for transfer and send operations for system accounts Part 1 (#11359) Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com> commit c9e8586 Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Thu Feb 8 12:03:19 2024 -0500 feat: Check platform status before syncing (#11429) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit d2e1b6b Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Thu Feb 8 12:02:45 2024 -0500 feat: Implement task scheduler squelching (#11398) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit 7801c39 Author: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com> Date: Thu Feb 8 16:29:39 2024 +0000 fix: 10904 Log catastrophic failures during ingest (#11415) Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com> commit 71c039e Author: Lev Povolotsky <16233475+povolev15@users.noreply.github.com> Date: Thu Feb 8 11:13:27 2024 -0500 fix: transaction fee in record for mono code (#11434) Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> commit 581be44 Author: Edward Wertz <123979964+edward-swirldslabs@users.noreply.github.com> Date: Thu Feb 8 09:27:10 2024 -0600 chore: move RandomAddressBookGenerator from swirlds-common to swirlds-platform-core (#11428) Signed-off-by: Edward Wertz <edward@swirldslabs.com> commit e68ec56 Author: Georgi Lazarov <glazarov95@gmail.com> Date: Thu Feb 8 14:55:05 2024 +0200 fix: revert changes from enabling fuzzy matching for TokenUpdatePrecompileSuite (#11419) Signed-off-by: georgi-l95 <glazarov95@gmail.com> commit 77d207f Author: Nikolay Atanasow <n.atanasow94@gmail.com> Date: Thu Feb 8 08:46:56 2024 +0200 feat: address account nonce discrepancies mono (#11045) Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Co-authored-by: Ivo Yankov <ivo@devlabs.bg> commit a71e2fb Author: Maxi Tartaglia <152629744+mxtartaglia-sl@users.noreply.github.com> Date: Wed Feb 7 17:41:56 2024 -0300 fix: 11391adapting DurationGauge naming to conventions (#11416) Signed-off-by: mxtartaglia <maxi@swirldslabs.com> commit 60b9677 Author: Michael Heinrichs <netopyr@users.noreply.github.com> Date: Wed Feb 7 21:22:42 2024 +0100 fix: Fix generated metric names (#11423) Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com> commit 5141ad3 Author: Michael Heinrichs <netopyr@users.noreply.github.com> Date: Wed Feb 7 13:54:48 2024 +0100 perf: Evaluate logging parameters only when needed (#11413) Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com> commit ab5390d Author: Michael Heinrichs <netopyr@users.noreply.github.com> Date: Wed Feb 7 13:53:33 2024 +0100 perf: Warm tokens as they are also on-disk now (#11412) Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com> commit 93bd4e5 Author: Hendrik Ebbers <hendrik.ebbers@web.de> Date: Wed Feb 7 10:42:09 2024 +0100 chore: Merkle test fixtures moved (#11382) Signed-off-by: Hendrik Ebbers <hendrik.ebbers@web.de> commit 2258784 Author: Mustafa Uzun <mustafa.uzun@limechain.tech> Date: Wed Feb 7 09:04:51 2024 +0200 fix: matching the signature for NonFungibleTokenInfo and FungibleTokenInfo on failure (#11133) Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech> commit 0949d53 Author: Michael Tinker <michael.tinker@swirldslabs.com> Date: Tue Feb 6 14:42:24 2024 -0600 chore: reload config from saved state (#11341) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> commit 22a67b0 Author: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com> Date: Tue Feb 6 13:56:55 2024 -0600 chore: Update protobuf version on develop (#11355) Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> commit 53bb6ce Author: Michael Tinker <michael.tinker@swirldslabs.com> Date: Tue Feb 6 13:52:53 2024 -0600 chore: add `-l` option to diff limited interval sizes (#11361) Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> Co-authored-by: Iris Simon <iris.simon@swirldslabs.com> Co-authored-by: Iris Simon <122310714+iwsimon@users.noreply.github.com> commit be761d1 Author: Michael Heinrichs <netopyr@users.noreply.github.com> Date: Tue Feb 6 18:43:18 2024 +0100 chore: Update PBJ dependency (#11397) Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com> commit 00e33b1 Author: Petar Tonev <petar.tonev@limechain.tech> Date: Tue Feb 6 17:45:03 2024 +0200 fix: token associations modular dumper (#11242) commit 240d7b8 Author: Georgi Lazarov <glazarov95@gmail.com> Date: Tue Feb 6 17:40:03 2024 +0200 feat: enable fuzzy record matching for `TokenUpdatePrecompileSuite` (#11008) Signed-off-by: georgi-l95 <glazarov95@gmail.com> commit 4324340 Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Tue Feb 6 08:48:03 2024 -0500 fix: Modify where components look to indicate overloaded intake (#11369) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit 3cf9f8c Author: JivkoKelchev <zhivko.kelchev@limechain.tech> Date: Tue Feb 6 12:44:49 2024 +0700 fix: 10315 halt on wrong token type (ERCPrecompileSuite fuzzy match) (#11164) Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech> Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> commit 1c6c69f Author: artemananiev <33361937+artemananiev@users.noreply.github.com> Date: Mon Feb 5 16:09:23 2024 -0800 fix: 11298: VirtualMapReconnectTest fails intermittently with path not in range log message (#11370) Reviewed-by: Anthony Petrov <anthony@swirldslabs.com>, Ivan Malygin <ivan@swirldslabs.com> Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com> commit c9ce0e8 Author: Matt Hess <matt.hess@swirldslabs.com> Date: Mon Feb 5 15:23:21 2024 -0600 fix: Return invalid token even if expected decimals are present (#11342) Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> commit 6c654d9 Author: Kore Aguda <157432197+kfa-aguda@users.noreply.github.com> Date: Mon Feb 5 12:58:28 2024 -0600 fix: broken unit test (#11233) Signed-off-by: Kore Aguda <kore@swirldslabs.com> commit 9c1f467 Author: Austin Littley <102969658+alittley@users.noreply.github.com> Date: Mon Feb 5 12:01:11 2024 -0500 feat: Migrate transaction handling to framework (#11144) Signed-off-by: Austin Littley <austin@swirldslabs.com> commit eaca230 Author: Lazar Petrovic <lpetrovic05@gmail.com> Date: Mon Feb 5 17:49:40 2024 +0100 chore: remove hashgraph demo (#11352) Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> commit bd1288f Author: Kelly Greco <82919061+poulok@users.noreply.github.com> Date: Mon Feb 5 09:15:05 2024 -0600 chore: Add `orderedSolderTo` method to OutputWire (#11330) Signed-off-by: Kelly Greco <kelly@swirldslabs.com> commit 831f644 Author: Lazar Petrovic <lpetrovic05@gmail.com> Date: Mon Feb 5 11:07:51 2024 +0100 chore: Create ISS detector component (#11075) Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com> commit 8bda7b2 Author: artemananiev <33361937+artemananiev@users.noreply.github.com> Date: Fri Feb 2 20:16:05 2024 -0800 fix: 11348: The fix for 11231 doesn't cover ParsedBucket (#11349) Fixes: #11348 Reviewed-by: Oleg Mazurov <oleg.mazurov@swirldslabs.com> Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com> commit 328d3dd Author: lukelee-sl <109538178+lukelee-sl@users.noreply.github.com> Date: Fri Feb 2 15:20:54 2024 -0800 feat: address cold read issue in ExtCodeHash operation (#11323) Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com> commit 8b7a581 Author: Richard Bair <rbair23@users.noreply.github.com> Date: Fri Feb 2 15:09:35 2024 -0800 chore: Update throttles.json (#11339) Signed-off-by: Richard Bair <rbair23@users.noreply.github.com> commit 21b682e Author: artemananiev <33361937+artemananiev@users.noreply.github.com> Date: Fri Feb 2 11:21:33 2024 -0800 feat: 11231: Improved virtual node remover (#11268) Fixes: #11231 Reviewed-by: Anthony Petrov <anthony@swirldslabs.com>, Austin Littley <austin@swirldslabs.com>, Ivan Malygin <ivan@swirldslabs.com>, Joseph Sinclair <joseph.sinclair@swirldslabs.com>, Oleg Mazurov <oleg.mazurov@swirldslabs.com> Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com> commit ed3218f Author: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com> Date: Fri Feb 2 11:37:53 2024 -0600 chore: Fix Some other issues faced during differential testing for 15 min window (#11297) Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Cody Littley <cody@swirldslabs.com> Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> Signed-off-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech> Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> Co-authored-by: Matt Hess <matt.hess@swirldslabs.com> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Cody Littley <cody@swirldslabs.com> Co-authored-by: Iris Simon <iris.simon@swirldslabs.com> Co-authored-by: Zhivko Kelchev <zhivko.kelchev@limechain.tech> Co-authored-by: Lev Povolotsky <lev@swirldslabs.com> commit 792f0e3 Author: Cody Littley <56973212+cody-littley@users.noreply.github.com> Date: Fri Feb 2 10:10:22 2024 -0600 fix: rejected execution in wiring framework (#11293) Signed-off-by: Cody Littley <cody@swirldslabs.com> commit b27b4f8 Author: Neeharika Sompalli <52669918+Neeharika-Sompalli@users.noreply.github.com> Date: Fri Feb 2 09:31:19 2024 -0600 chore: fix the record mismatch for `prng` transactions (#11238) Signed-off-by: Matt Hess <matt.hess@swirldslabs.com> Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com> Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Signed-off-by: Cody Littley <cody@swirldslabs.com> Signed-off-by: Iris Simon <iris.simon@swirldslabs.com> Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> Co-authored-by: Matt Hess <matt.hess@swirldslabs.com> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Cody Littley <cody@swirldslabs.com> Co-authored-by: Iris Simon <iris.simon@swirldslabs.com> Co-authored-by: Lev Povolotsky <lev@swirldslabs.com> commit 356d5be Author: Cody Littley <56973212+cody-littley@users.noreply.github.com> Date: Fri Feb 2 08:18:13 2024 -0600 chore: drop support for async hashing (#11319) Signed-off-by: Cody Littley <cody@swirldslabs.com>

Executing eth_call against HTS precompile address without selector results in 500. `ERROR reactor-http-nio-5 c.h.m.w.c.ContractController Generic error: java.lang.IndexOutOfBoundsException: index is out of bounds`. Also, `Bytes.fromHexString` throws error when the input data is invalid which results in status 500. This PR: 1. Adds input checks in the precompiled contracts similar to services (see hashgraph/hedera-services#11359) 2. Throws `InvalidParametersException` and returns 400 `BadRequest` if the input data cannot be parsed to `Bytes` 3. Adds additional check in `HtsPrecompiledContract` that was missing from the services copied code. --------- Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

test: add tests for precompile transfers and fix reverting

1669a7b

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

0xivanov added Test Development Test Development Limechain Work planned for the LimeChain team labels Feb 5, 2024

0xivanov self-assigned this Feb 5, 2024

0xivanov requested review from a team and tinker-michaelj as code owners February 5, 2024 15:29

0xivanov requested review from kimbor and acuarica February 5, 2024 15:29

Merge branch 'develop' into 11138-hapi-tests-for-transfer-and-send-op…

fc86dbf

…erations-for-system-accounts

stoqnkpL previously approved these changes Feb 5, 2024

View reviewed changes

Nana-EC requested review from lukelee-sl and david-bakin-sl February 5, 2024 16:05

stoqnkpL reviewed Feb 5, 2024

View reviewed changes

stoqnkpL self-requested a review February 5, 2024 16:37

0xivanov commented Feb 5, 2024

View reviewed changes

...m/hedera/node/app/service/contract/impl/exec/systemcontracts/ExchangeRateSystemContract.java Outdated Show resolved Hide resolved

fix: address PR comments

1726ca2

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

0xivanov dismissed stoqnkpL’s stale review via 1726ca2 February 5, 2024 17:26

tinker-michaelj requested changes Feb 5, 2024

View reviewed changes

...hedera/node/app/service/mono/store/contracts/precompile/ExchangeRatePrecompiledContract.java Show resolved Hide resolved

chore: update from develop

e4291ec

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

0xivanov added 2 commits February 6, 2024 13:27

test: fix unit tests

a6199ef

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

test: fix integration tests

33bbcca

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

tinker-michaelj previously approved these changes Feb 6, 2024

View reviewed changes

Neeharika-Sompalli mentioned this pull request Feb 6, 2024

chore: fix IndexOutOfBoundsException when invalid function selector #11373

Closed

lukelee-sl reviewed Feb 6, 2024

View reviewed changes

...java/com/hedera/node/app/service/mono/store/contracts/precompile/HTSPrecompiledContract.java Outdated Show resolved Hide resolved

lukelee-sl reviewed Feb 6, 2024

View reviewed changes

chore: address PR comments

d6b199c

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

0xivanov dismissed tinker-michaelj’s stale review via d6b199c February 7, 2024 15:57

lukelee-sl previously approved these changes Feb 7, 2024

View reviewed changes

Neeharika-Sompalli previously approved these changes Feb 7, 2024

View reviewed changes

tinker-michaelj previously approved these changes Feb 7, 2024

View reviewed changes

0xivanov added 2 commits February 8, 2024 10:58

chore: update from develop

ffed683

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

test: fix balance checker test

700e7f3

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

0xivanov dismissed stale reviews from tinker-michaelj, Neeharika-Sompalli, and lukelee-sl via 700e7f3 February 8, 2024 10:16

tinker-michaelj approved these changes Feb 8, 2024

View reviewed changes

stoqnkpL merged commit acaa4a1 into develop Feb 8, 2024
43 of 44 checks passed

stoqnkpL deleted the 11138-hapi-tests-for-transfer-and-send-operations-for-system-accounts branch February 8, 2024 17:08

stoqnkpL pushed a commit that referenced this pull request Feb 8, 2024

test: Create hapi tests for transfer and send operations for system a…

eae607b

…ccounts Part 1 (#11359) Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>

stoqnkpL mentioned this pull request Feb 8, 2024

chore: Cherry pick Create hapi tests for transfer and send operations for system accounts #11452

Merged

2 tasks

kimbor mentioned this pull request Feb 12, 2024

Fix IndexOutOfBoundsException when Invalid function selector is provided #11371

Closed

0xivanov mentioned this pull request Feb 29, 2024

Fix IndexOutOfBoundsException for direct precompile calls hashgraph/hedera-mirror-node#7825

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Create hapi tests for transfer and send operations for system accounts Part 1 #11359

test: Create hapi tests for transfer and send operations for system accounts Part 1 #11359

0xivanov commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

codecov bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

stoqnkpL left a comment

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

0xivanov commented Feb 5, 2024 •

edited

tinker-michaelj left a comment

codecov-commenter commented Feb 6, 2024 •

edited

tinker-michaelj left a comment

lukelee-sl left a comment

lukelee-sl left a comment

Neeharika-Sompalli left a comment

tinker-michaelj left a comment

0xivanov commented Feb 8, 2024

tinker-michaelj left a comment

test: Create hapi tests for transfer and send operations for system accounts Part 1 #11359

test: Create hapi tests for transfer and send operations for system accounts Part 1 #11359

Conversation

0xivanov commented Feb 5, 2024 • edited

github-actions bot commented Feb 5, 2024 • edited

Node: HAPI Test (Restart) Results

github-actions bot commented Feb 5, 2024 • edited

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Feb 5, 2024 • edited

Node: HAPI Test (Token) Results

github-actions bot commented Feb 5, 2024 • edited

Node: E2E Test Results

github-actions bot commented Feb 5, 2024 • edited

Node: HAPI Test (Crypto) Results

github-actions bot commented Feb 5, 2024 • edited

Node: Unit Test Results

codecov bot commented Feb 5, 2024 • edited

Codecov Report

github-actions bot commented Feb 5, 2024 • edited

Node: HAPI Test (Misc) Results

github-actions bot commented Feb 5, 2024 • edited

Node: HAPI Test (Time Consuming) Results

stoqnkpL left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 5, 2024 • edited

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Feb 5, 2024 • edited

Node: Integration Test Results

0xivanov commented Feb 5, 2024 • edited

tinker-michaelj left a comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 6, 2024 • edited

Codecov Report

tinker-michaelj left a comment

Choose a reason for hiding this comment

lukelee-sl left a comment

Choose a reason for hiding this comment

lukelee-sl left a comment

Choose a reason for hiding this comment

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

0xivanov commented Feb 8, 2024

tinker-michaelj left a comment

Choose a reason for hiding this comment

0xivanov commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

codecov bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

github-actions bot commented Feb 5, 2024 •

edited

0xivanov commented Feb 5, 2024 •

edited

codecov-commenter commented Feb 6, 2024 •

edited