chore: fix IndexOutOfBoundsException when invalid function selector
#11373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neeharika-Sompalli
requested review from
netopyr,
tinker-michaelj,
lukelee-sl and
Nana-EC
tinker-michaelj
approved these changes
Feb 5, 2024
tinker-michaelj
changed the title
IndexOutOfBoundsException when invalid function selectorIndexOutOfBoundsException when invalid function selector
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #11373 +/- ##
=============================================
- Coverage 63.02% 63.02% -0.01%
- Complexity 31057 31060 +3
=============================================
Files 3367 3367
Lines 137589 137591 +2
Branches 14461 14462 +1
=============================================
+ Hits 86720 86721 +1
- Misses 47170 47175 +5
+ Partials 3699 3695 -4 ☔ View full report in Codecov by Sentry. |
|
Will be fixed by #11359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11371
Fix
IndexOutOfBoundsExceptionto not throwFAIL_INVALIDwhen invalid function selector is provided