feat: Differential testing: Enhance account store dumper to handle modular representation #11489

vtronkov · 2024-02-12T14:09:23Z

Description:

Adding dumpers for the accounts

Related issue(s):

Fixes #10990

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

github-actions · 2024-02-12T14:35:41Z

Node: HAPI Test (Restart) Results

2 tests 2 ✔️ 5m 14s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T14:38:44Z

Node: HAPI Test (Node Death Reconnect) Results

2 tests 2 ✔️ 7m 47s ⏱️
2 suites 0 💤
2 files 0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T14:50:36Z

Node: HAPI Test (Token) Results

190 tests 190 ✔️ 18m 53s ⏱️
  14 suites     0 💤
  14 files     0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T14:55:15Z

Node: E2E Test Results

    1 files     1 suites 23m 27s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T14:59:36Z

Node: HAPI Test (Crypto) Results

214 tests 214 ✔️ 23m 37s ⏱️
  23 suites     0 💤
  23 files     0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T15:11:17Z

Node: HAPI Test (Misc) Results

431 tests 421 ✔️ 35m 46s ⏱️
  75 suites   10 💤
  75 files     0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T15:23:34Z

Node: HAPI Test (Time Consuming) Results

21 tests 21 ✔️ 54m 5s ⏱️
  3 suites   0 💤
  3 files   0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T15:35:44Z

Node: Integration Test Results

    5 files     5 suites 1h 5m 31s ⏱️
322 tests 322 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-12T15:39:19Z

Node: HAPI Test (Smart Contract) Results

494 tests 491 ✔️ 57m 2s ⏱️
  55 suites     3 💤
  55 files     0 ❌

Results for commit 9e4c02d.

♻️ This comment has been updated with latest results.

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/AccountDumpUtils.java

github-actions · 2024-02-14T16:32:14Z

Node: Unit Test Results

    2 259 files +  7     2 259 suites +7 2h 46m 30s ⏱️ + 32m 39s
111 012 tests +14 110 970 ✔️ +14 42 💤 ±0 0 ❌ ±0
119 400 runs +15 119 358 ✔️ +15 42 💤 ±0 0 ❌ ±0

Results for commit 9e4c02d. ± Comparison against base commit 601f92b.

♻️ This comment has been updated with latest results.

codecov · 2024-02-14T16:33:23Z

Codecov Report

Attention: 368 lines in your changes are missing coverage. Please review.

Comparison is base (601f92b) 61.91% compared to head (9e4c02d) 61.74%.
Report is 14 commits behind head on develop.

Files	Patch %	Lines
...hedera/node/app/bbm/accounts/AccountDumpUtils.java	0.00%	174 Missing ⚠️
...om/hedera/node/app/bbm/accounts/HederaAccount.java	0.00%	112 Missing ⚠️
...com/hedera/node/app/bbm/utils/ThingsToStrings.java	0.00%	78 Missing ⚠️
...main/java/com/hedera/node/app/bbm/StateDumper.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11489      +/-   ##
=============================================
- Coverage      61.91%   61.74%   -0.18%     
+ Complexity     30671    30661      -10     
=============================================
  Files           3381     3381              
  Lines         138289   138609     +320     
  Branches       14514    14527      +13     
=============================================
- Hits           85627    85585      -42     
- Misses         48995    49354     +359     
- Partials        3667     3670       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

david-bakin-sl

Still working on a full review - but since you've already pushed changes, here were my initial comments (before I got distracted)

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/utils/ThingsToStrings.java

david-bakin-sl

LGTM!

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/HederaAccount.java

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

david-bakin-sl

Nothing new to comment on, TYVM, and sorry for the delay!

LGTM

tinker-michaelj

LGTM, tyvm @vtronkov !

…dular representation (#11489) Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

…dular representation (#11489) Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> (cherry picked from commit 93c1a1e)

feat: add account dumpers

9a6ffef

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

vtronkov added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Feb 12, 2024

vtronkov self-assigned this Feb 12, 2024

nit: polishing

c3ff822

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

vtronkov marked this pull request as ready for review February 12, 2024 14:22

vtronkov requested a review from a team as a code owner February 12, 2024 14:22

vtronkov requested a review from jasperpotts February 12, 2024 14:22

vtronkov mentioned this pull request Feb 14, 2024

feat: Differential testing: Enhance contract bytecode dumper to handle modular representation #11523

Merged

nit: fix the mono account type and add private constructor

561bbf5

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

david-bakin-sl self-requested a review February 14, 2024 15:21

david-bakin-sl reviewed Feb 14, 2024

View reviewed changes

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/AccountDumpUtils.java Outdated Show resolved Hide resolved

david-bakin-sl reviewed Feb 14, 2024

View reviewed changes

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/AccountDumpUtils.java Outdated Show resolved Hide resolved

vtronkov added 2 commits February 15, 2024 08:40

Merge branch 'develop' into 10990-account-store-mod-dumper

38df24a

# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java

fix: TODOs

1037caf

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

vtronkov requested a review from david-bakin-sl February 15, 2024 14:18

nit: clean-up

5dc901a

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

david-bakin-sl reviewed Feb 15, 2024

View reviewed changes

david-bakin-sl previously approved these changes Feb 15, 2024

View reviewed changes

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/HederaAccount.java Show resolved Hide resolved

hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/HederaAccount.java Outdated Show resolved Hide resolved

fix: PR comments

9e4c02d

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

vtronkov dismissed david-bakin-sl’s stale review via 9e4c02d February 16, 2024 07:32

vtronkov requested a review from david-bakin-sl February 16, 2024 07:32

david-bakin-sl approved these changes Feb 27, 2024

View reviewed changes

tinker-michaelj approved these changes Feb 28, 2024

View reviewed changes

vtronkov merged commit 93c1a1e into develop Feb 28, 2024
47 of 49 checks passed

vtronkov deleted the 10990-account-store-mod-dumper branch February 28, 2024 06:47

imalygin pushed a commit that referenced this pull request Mar 4, 2024

feat: Differential testing: Enhance account store dumper to handle mo…

32cbae1

…dular representation (#11489) Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

netopyr mentioned this pull request Mar 19, 2024

feat: Cherry-pick: Enhance account store dumper to handle modular representation #12213

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Differential testing: Enhance account store dumper to handle modular representation #11489

feat: Differential testing: Enhance account store dumper to handle modular representation #11489

vtronkov commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

codecov bot commented Feb 14, 2024 •

edited

Loading

david-bakin-sl left a comment

david-bakin-sl left a comment

david-bakin-sl left a comment

tinker-michaelj left a comment

feat: Differential testing: Enhance account store dumper to handle modular representation #11489

feat: Differential testing: Enhance account store dumper to handle modular representation #11489

Conversation

vtronkov commented Feb 12, 2024 • edited Loading

github-actions bot commented Feb 12, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: E2E Test Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: Integration Test Results

github-actions bot commented Feb 12, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Feb 14, 2024 • edited Loading

Node: Unit Test Results

codecov bot commented Feb 14, 2024 • edited Loading

Codecov Report

david-bakin-sl left a comment

Choose a reason for hiding this comment

david-bakin-sl left a comment

Choose a reason for hiding this comment

david-bakin-sl left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

vtronkov commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Feb 14, 2024 •

edited

Loading

codecov bot commented Feb 14, 2024 •

edited

Loading