-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Differential testing: Enhance contract bytecode dumper to handle modular representation #11523
Conversation
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com> # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/FileId.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/FileStore.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/HederaFile.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/SystemFileType.java
Outdated
Show resolved
Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/ContractBytecodesDumpUtils.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 10990-account-store-mod-dumper #11523 +/- ##
====================================================================
- Coverage 61.74% 61.67% -0.08%
- Complexity 30661 30668 +7
====================================================================
Files 3381 3389 +8
Lines 138609 138823 +214
Branches 14527 14536 +9
====================================================================
+ Hits 85585 85615 +30
- Misses 49354 49546 +192
+ Partials 3670 3662 -8 ☔ View full report in Codecov by Sentry. |
…ecode-dumper2 # Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some optional items (but also pending MichaelT's check that getting the contract bytecode store is correct).
...in/java/com/hedera/node/app/service/contract/impl/state/InitialModServiceContractSchema.java
Outdated
Show resolved
Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/ContractBytecodesDumpUtils.java
Outdated
Show resolved
Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/ContractBytecodesDumpUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/ContractUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @vtronkov !
The base branch was changed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #11523 +/- ##
=============================================
- Coverage 61.88% 61.67% -0.22%
+ Complexity 30734 30668 -66
=============================================
Files 3388 3389 +1
Lines 138729 138823 +94
Branches 14552 14536 -16
=============================================
- Hits 85852 85615 -237
- Misses 49166 49546 +380
+ Partials 3711 3662 -49 ☔ View full report in Codecov by Sentry. |
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/AccountDumpUtils.java
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
Related issue(s):
Fixes #10994
Notes for reviewer: