Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Differential testing: Enhance contract bytecode dumper to handle modular representation #11523

Merged
merged 20 commits into from
Feb 29, 2024
Merged

feat: Differential testing: Enhance contract bytecode dumper to handle modular representation #11523

merged 20 commits into from
Feb 29, 2024

Conversation

vtronkov
Copy link
Contributor

@vtronkov vtronkov commented Feb 14, 2024 •
edited

Description:

  • Adding dumpers for contract bytecodes

Related issue(s):

Fixes #10994

Notes for reviewer:

@vtronkov
feat: add account dumpers
9a6ffef 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
nit: polishing
c3ff822 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
feat: add mono dumper
5199624 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java
@vtronkov
feat: mod dumper
2dcc2de 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov vtronkov self-assigned this Feb 14, 2024
@vtronkov vtronkov added Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization labels Feb 14, 2024
@vtronkov
nit: polishing
e582030 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov vtronkov changed the title 10994 contract bytecode dumper feat: Differential testing: Enhance contract bytecode dumper to handle modular representation Feb 14, 2024
@vtronkov vtronkov marked this pull request as ready for review February 14, 2024 14:45
@vtronkov vtronkov requested a review from a team as a code owner February 14, 2024 14:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  5m 22s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  7m 50s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: HAPI Test (Token) Results

190 tests   190 ✔️  17m 15s ⏱️
  14 suites      0 💤
  14 files        0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@vtronkov
nit: fix the mono account type and add private constructor
561bbf5 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: E2E Test Results

    1 files      1 suites   23m 11s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: HAPI Test (Crypto) Results

214 tests   214 ✔️  25m 16s ⏱️
  23 suites      0 💤
  23 files        0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: HAPI Test (Misc) Results

436 tests   426 ✔️  39m 12s ⏱️
  76 suites    10 💤
  76 files        0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  53m 49s ⏱️
  3 suites    0 💤
  3 files      0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: Integration Test Results

    5 files      5 suites   1h 6m 24s ⏱️
322 tests 322 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: HAPI Test (Smart Contract) Results

494 tests   491 ✔️  57m 39s ⏱️
  55 suites      3 💤
  55 files        0 ❌

Results for commit 2e3511a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2024 •
edited

Node: Unit Test Results

    2 259 files  ±0      2 259 suites  ±0   2h 36m 47s ⏱️ - 24m 45s
111 106 tests ±0  111 066 ✔️ ±0  40 💤 ±0  0 ❌ ±0 
119 551 runs  ±0  119 511 ✔️ ±0  40 💤 ±0  0 ❌ ±0 

Results for commit 2e3511a. ± Comparison against base commit c00358e.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited

Codecov Report

Attention: 168 lines in your changes are missing coverage. Please review.

Comparison is base (9e4c02d) 61.74% compared to head (3ead2ff) 61.67%.

Files Patch % Lines
.../app/bbm/contracts/ContractBytecodesDumpUtils.java 0.00% 97 Missing ⚠️
...m/hedera/node/app/bbm/contracts/ContractUtils.java 0.00% 31 Missing ⚠️
...va/com/hedera/node/app/bbm/contracts/Contract.java 0.00% 23 Missing ⚠️
...main/java/com/hedera/node/app/bbm/StateDumper.java 0.00% 7 Missing ⚠️
.../hedera/node/app/bbm/contracts/ByteArrayAsKey.java 0.00% 4 Missing ⚠️
...va/com/hedera/node/app/bbm/contracts/Validity.java 0.00% 3 Missing ⚠️
...a/com/hedera/node/app/bbm/contracts/Contracts.java 0.00% 1 Missing ⚠️
...ain/java/com/hedera/node/app/bbm/files/FileId.java 0.00% 1 Missing ⚠️
...java/com/hedera/node/app/bbm/files/HederaFile.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                         Coverage Diff                          @@
##             10990-account-store-mod-dumper   #11523      +/-   ##
====================================================================
- Coverage                             61.74%   61.67%   -0.08%     
- Complexity                            30661    30668       +7     
====================================================================
  Files                                  3381     3389       +8     
  Lines                                138609   138823     +214     
  Branches                              14527    14536       +9     
====================================================================
+ Hits                                  85585    85615      +30     
- Misses                                49354    49546     +192     
+ Partials                               3670     3662       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vtronkov
Merge branch '10990-account-store-mod-dumper' into 10994-contract-byt…
2529b6a 
…ecode-dumper2

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java
@vtronkov
refactor: delete the fields and classes duplicated by the merged PR
a7dd490 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
nit: add private constructor and spotless
f118e84 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@yosiftouma yosiftouma linked an issue Feb 15, 2024 that may be closed by this pull request
Differential testing: Enhance contract bytecode dumper to handle modular representation #10994
Closed
@vtronkov
fix: use the correct VirtualMap for mod contract store
40b3be3 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov vtronkov requested a review from a team as a code owner February 15, 2024 09:00
@vtronkov
fix: TODOs
1037caf 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
nit: clean-up
5dc901a 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
Merge branch '10990-account-store-mod-dumper' into 10994-contract-byt…
98c7822 
…ecode-dumper2
david-bakin-sl
david-bakin-sl previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some optional items (but also pending MichaelT's check that getting the contract bytecode store is correct).

...in/java/com/hedera/node/app/service/contract/impl/state/InitialModServiceContractSchema.java Outdated Show resolved Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/ContractBytecodesDumpUtils.java Outdated Show resolved Hide resolved
...e/hedera-app/src/main/java/com/hedera/node/app/bbm/contracts/ContractBytecodesDumpUtils.java Outdated Show resolved Hide resolved
@vtronkov
fix: PR comments
9e4c02d 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
Merge branch '10990-account-store-mod-dumper' into 10994-contract-byt…
4890f56 
…ecode-dumper2
@vtronkov
refactor: moving methods into a util class and nit stuff
dfc70e3 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
@vtronkov
fix: mod dumper
3ead2ff 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
tinker-michaelj
tinker-michaelj previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @vtronkov !

Base automatically changed from 10990-account-store-mod-dumper to develop February 28, 2024 06:47
@vtronkov vtronkov dismissed stale reviews from tinker-michaelj and david-bakin-sl February 28, 2024 06:47

The base branch was changed.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 536 lines in your changes are missing coverage. Please review.

Project coverage is 61.67%. Comparing base (c00358e) to head (3ead2ff).

❗ Current head 3ead2ff differs from pull request most recent head 2e3511a. Consider uploading reports for the commit 2e3511a to get more accurate results

Files Patch % Lines
...hedera/node/app/bbm/accounts/AccountDumpUtils.java 0.00% 174 Missing ⚠️
...om/hedera/node/app/bbm/accounts/HederaAccount.java 0.00% 112 Missing ⚠️
.../app/bbm/contracts/ContractBytecodesDumpUtils.java 0.00% 97 Missing ⚠️
...com/hedera/node/app/bbm/utils/ThingsToStrings.java 0.00% 78 Missing ⚠️
...m/hedera/node/app/bbm/contracts/ContractUtils.java 0.00% 31 Missing ⚠️
...va/com/hedera/node/app/bbm/contracts/Contract.java 0.00% 23 Missing ⚠️
...main/java/com/hedera/node/app/bbm/StateDumper.java 0.00% 11 Missing ⚠️
.../hedera/node/app/bbm/contracts/ByteArrayAsKey.java 0.00% 4 Missing ⚠️
...va/com/hedera/node/app/bbm/contracts/Validity.java 0.00% 3 Missing ⚠️
...a/com/hedera/node/app/bbm/contracts/Contracts.java 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@              Coverage Diff              @@
##             develop   #11523      +/-   ##
=============================================
- Coverage      61.88%   61.67%   -0.22%     
+ Complexity     30734    30668      -66     
=============================================
  Files           3388     3389       +1     
  Lines         138729   138823      +94     
  Branches       14552    14536      -16     
=============================================
- Hits           85852    85615     -237     
- Misses         49166    49546     +380     
+ Partials        3711     3662      -49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vtronkov
Merge branch 'develop' into 10994-contract-bytecode-dumper2
6de05d8 
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/StateDumper.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/bbm/accounts/AccountDumpUtils.java
@vtronkov
nit: spotless
2e3511a 
Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
david-bakin-sl
david-bakin-sl approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tinker-michaelj
tinker-michaelj approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vtronkov vtronkov merged commit b58eb1a into develop Feb 29, 2024
45 checks passed
@vtronkov vtronkov deleted the 10994-contract-bytecode-dumper2 branch February 29, 2024 05:12
netopyr pushed a commit that referenced this pull request Mar 19, 2024
@vtronkov @netopyr
feat: Differential testing: Enhance contract bytecode dumper to handl…
c805e09 
…e modular representation (#11523)

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
(cherry picked from commit b58eb1a)
@netopyr netopyr mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@david-bakin-sl david-bakin-sl david-bakin-sl approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Awaiting requested review from Neeharika-Sompalli Neeharika-Sompalli is a code owner automatically assigned from hashgraph/hedera-base

Assignees

@vtronkov vtronkov

Labels
Limechain Work planned for the LimeChain team Modularization Issues or PRs related to modularization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differential testing: Enhance contract bytecode dumper to handle modular representation
4 participants
@vtronkov @codecov-commenter @tinker-michaelj @david-bakin-sl