Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: 11138 - Create hapi tests for transfer and send operations for system accounts Part 2 #11490

Conversation

0xivanov
Copy link
Contributor

Description:
Calling operations on system accounts in hedera may differ from ethereum.
We need to add hapi tests for them and check and document the behaviour.

Related issue(s):

Fixes #11138

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov added Test Development Test Development Limechain Work planned for the LimeChain team labels Feb 12, 2024
@0xivanov 0xivanov self-assigned this Feb 12, 2024
Copy link

github-actions bot commented Feb 12, 2024

Node: HAPI Test (Restart) Results

3 tests   3 ✅  7m 0s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 50s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

Node: HAPI Test (Token) Results

 20 files   20 suites   6m 23s ⏱️
265 tests 265 ✅ 0 💤 0 ❌
340 runs  340 ✅ 0 💤 0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

Node: E2E Test Results

    1 files      1 suites   25m 3s ⏱️
311 tests 311 ✔️ 0 💤 0
333 runs  333 ✔️ 0 💤 0

Results for commit d968a8d.

Copy link

github-actions bot commented Feb 12, 2024

Node: HAPI Test (Crypto) Results

 24 files   24 suites   12m 18s ⏱️
364 tests 364 ✅ 0 💤 0 ❌
371 runs  371 ✅ 0 💤 0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

Node: HAPI Test (Misc) Results

 51 files   51 suites   21m 13s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
375 runs  375 ✅ 0 💤 0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  23m 3s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

Node: Integration Test Results

    5 files      5 suites   1h 5m 59s ⏱️
319 tests 317 ✔️ 0 💤 2
331 runs  329 ✔️ 0 💤 2

For more details on these failures, see this check.

Results for commit d968a8d.

Copy link

github-actions bot commented Feb 12, 2024

Node: HAPI Test (Smart Contract) Results

 72 files   72 suites   24m 46s ⏱️
619 tests 619 ✅ 0 💤 0 ❌
674 runs  674 ✅ 0 💤 0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 12, 2024

Node: Unit Test Results

  1 536 files    1 536 suites   2h 58m 13s ⏱️
108 524 tests 108 465 ✅ 59 💤 0 ❌
116 818 runs  116 759 ✅ 59 💤 0 ❌

Results for commit ffc330b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.03%. Comparing base (9973fae) to head (d968a8d).
Report is 79 commits behind head on develop.

Current head d968a8d differs from pull request most recent head ffc330b

Please upload reports for the commit ffc330b to get more accurate results.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #11490      +/-   ##
=============================================
- Coverage      67.58%   62.03%   -5.56%     
+ Complexity     36486    30654    -5832     
=============================================
  Files           3732     3372     -360     
  Lines         149767   137935   -11832     
  Branches       15571    14484    -1087     
=============================================
- Hits          101223    85562   -15661     
- Misses         44179    48700    +4521     
+ Partials        4365     3673     -692     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
…s-for-system-accounts' of https://github.com/hashgraph/hedera-services into 11138-Create-hapi-tests-for-transfer-and-send-operations-for-system-accounts
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
0xivanov and others added 2 commits May 29, 2024 12:05
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
…send-operations-for-system-accounts

Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev kselveliev added this to the v0.52 milestone Jun 27, 2024
@kselveliev kselveliev self-requested a review June 27, 2024 13:15
@kselveliev kselveliev marked this pull request as ready for review June 27, 2024 13:16
@kselveliev kselveliev requested review from a team as code owners June 27, 2024 13:16
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev kselveliev self-assigned this Jul 2, 2024
@Neeharika-Sompalli Neeharika-Sompalli merged commit 1735c64 into develop Jul 8, 2024
44 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 11138-Create-hapi-tests-for-transfer-and-send-operations-for-system-accounts branch July 8, 2024 18:24
netopyr added a commit that referenced this pull request Jul 8, 2024
* develop:
  test: 11138 - Create hapi tests for transfer and send operations for system accounts Part 2 (#11490)
  chore: enable update `HapiTest`s (#14105)
  feat(reconnect): record metrics using ReconnectMapStats (#14071)
  chore: Update codeowners for smart contracts contributors (#14154)
  build(deps): bump mikefarah/yq from 4.42.1 to 4.44.2 (#13905)
  build(deps): bump codecov/codecov-action from 4.1.0 to 4.5.0 (#13844)
  build(deps): bump io.netty:netty-transport from 4.1.87.Final to 4.1.111.Final in /hedera-dependency-versions (#13801)
  build(deps): bump docker/setup-buildx-action from 3.0.0 to 3.4.0 (#14167)
  chore: remove unneeded code (#14078)
  chore: Move test-only methods for signing messages out of hapi-utils to new util class in test-clients (#14155)
  docs: TSS-Library Proposal (#13808)
  docs: 13793 platform design proposal process (#14083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team Test Development Test Development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System accounts disambiguation: Create hapi tests for transfer and send operations for system accounts
3 participants