Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Cherry-pick: Enhance contract bytecode dumper to handle modular representation #12223

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: Cherry-pick: Enhance contract bytecode dumper to handle modular representation #12223

merged 1 commit into from
Mar 20, 2024

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Mar 19, 2024

Cherry pick of #11523

Fixes #10994

@vtronkov @netopyr
feat: Differential testing: Enhance contract bytecode dumper to handl…
c805e09 
…e modular representation (#11523)

Signed-off-by: Valentin Tronkov <99957253+vtronkov@users.noreply.github.com>
(cherry picked from commit b58eb1a)
@netopyr netopyr added this to the v0.48 milestone Mar 19, 2024
@netopyr netopyr requested a review from vtronkov March 19, 2024 17:43
@netopyr netopyr self-assigned this Mar 19, 2024
@netopyr netopyr requested a review from a team as a code owner March 19, 2024 17:43
@netopyr netopyr requested a review from rbair23 March 19, 2024 17:43
@github-actions GitHub Actions
Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  7m 21s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit c805e09.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Token) Results

199 tests   199 ✔️  18m 22s ⏱️
  16 suites      0 💤
  16 files        0 ❌

Results for commit c805e09.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Crypto) Results

214 tests   214 ✔️  27m 40s ⏱️
  23 suites      0 💤
  23 files        0 ❌

Results for commit c805e09.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.57%. Comparing base (bb18f8e) to head (bb18f8e).

❗ Current head bb18f8e differs from pull request most recent head c805e09. Consider uploading reports for the commit c805e09 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##             release/0.48   #12223   +/-   ##
===============================================
  Coverage           61.57%   61.57%           
  Complexity          30761    30761           
===============================================
  Files                3400     3400           
  Lines              139615   139615           
  Branches            14642    14642           
===============================================
  Hits                85967    85967           
  Misses              49907    49907           
  Partials             3741     3741

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Misc) Results

431 tests   421 ✔️  43m 12s ⏱️
  75 suites    10 💤
  75 files        0 ❌

Results for commit c805e09.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  54m 19s ⏱️
  3 suites    0 💤
  3 files      0 ❌

Results for commit c805e09.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Smart Contract) Results

494 tests   491 ✔️  58m 25s ⏱️
  55 suites      3 💤
  55 files        0 ❌

Results for commit c805e09.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 19, 2024 •
edited
Loading

Node: Unit Test Results

    2 263 files  ±0      2 263 suites  ±0   2h 27m 49s ⏱️ -48s
112 164 tests ±0  112 116 ✔️ +1  48 💤 ±0  0 ❌  - 1 
120 625 runs  ±0  120 577 ✔️ +1  48 💤 ±0  0 ❌  - 1 

Results for commit c805e09. ± Comparison against base commit bb18f8e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  5m 26s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit c805e09.

david-bakin-sl
david-bakin-sl approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netopyr netopyr merged commit 8863878 into release/0.48 Mar 20, 2024
48 of 49 checks passed
@netopyr netopyr deleted the 10994-contract-bytecode-dumper2-cherry-pick branch March 20, 2024 12:02
@poulok poulok modified the milestones: v0.48, v0.49 Apr 10, 2024
imalygin pushed a commit that referenced this pull request Apr 17, 2024
@netopyr @vtronkov @imalygin
feat: Cherry-pick: Enhance contract bytecode dumper to handle modular…
fb23ddd 
… representation (#12223)

Co-authored-by: Valentin Tronkov <valentin.tronkov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@vtronkov vtronkov vtronkov approved these changes

@david-bakin-sl david-bakin-sl david-bakin-sl approved these changes

@rbair23 rbair23 Awaiting requested review from rbair23 rbair23 is a code owner automatically assigned from hashgraph/hedera-base

Assignees

@netopyr netopyr

Labels
None yet
Projects
None yet
Milestone
v0.49
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@netopyr @codecov-commenter @Neeharika-Sompalli @vtronkov @david-bakin-sl @poulok