Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick Dont modify allowances on token reject #14289

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Neeharika-Sompalli
Copy link
Member

Cherry-pick #14282

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Copy link

Node: Unit Test Results

  1 542 files    1 542 suites   3h 25m 53s ⏱️
115 771 tests 115 712 ✅ 59 💤 0 ❌
124 086 runs  124 027 ✅ 59 💤 0 ❌

Results for commit 31e41bb.

Copy link

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 32s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 31e41bb.

Copy link

Node: HAPI Test (Restart) Results

3 tests   3 ✅  6m 13s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 31e41bb.

Copy link

Node: HAPI Test (Token) Results

 22 files   22 suites   7m 36s ⏱️
272 tests 272 ✅ 0 💤 0 ❌
350 runs  350 ✅ 0 💤 0 ❌

Results for commit 31e41bb.

Copy link

Node: HAPI Test (Crypto) Results

 24 files   24 suites   13m 26s ⏱️
362 tests 362 ✅ 0 💤 0 ❌
369 runs  369 ✅ 0 💤 0 ❌

Results for commit 31e41bb.

Copy link

Node: HAPI Test (Misc) Results

 51 files   51 suites   20m 10s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
375 runs  375 ✅ 0 💤 0 ❌

Results for commit 31e41bb.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @Neeharika-Sompalli !

Copy link

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  23m 8s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 31e41bb.

Copy link

Node: HAPI Test (Smart Contract) Results

 73 files   73 suites   28m 56s ⏱️
681 tests 681 ✅ 0 💤 0 ❌
735 runs  735 ✅ 0 💤 0 ❌

Results for commit 31e41bb.

Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neeharika-Sompalli Neeharika-Sompalli merged commit 2e496ce into release/0.52 Jul 17, 2024
60 of 76 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the cherry-pick-14282 branch July 17, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants