Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed allowances modification on TokenReject #14282

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Neeharika-Sompalli
Copy link
Member

Fixes #14271

Removed allowances modification on TokenReject

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
@Neeharika-Sompalli Neeharika-Sompalli requested review from a team as code owners July 17, 2024 15:57
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Jul 17, 2024
@Neeharika-Sompalli Neeharika-Sompalli added this to the v0.52 milestone Jul 17, 2024
@Neeharika-Sompalli Neeharika-Sompalli changed the title Removed allowances modification on TokenReject chore: Removed allowances modification on TokenReject Jul 17, 2024
Copy link

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 28s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 3ea4116.

Copy link

Node: HAPI Test (Token) Results

 22 files   22 suites   6m 36s ⏱️
272 tests 272 ✅ 0 💤 0 ❌
350 runs  350 ✅ 0 💤 0 ❌

Results for commit 3ea4116.

Copy link

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 28s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit 3ea4116.

Copy link

Node: HAPI Test (Crypto) Results

 24 files   24 suites   14m 39s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit 3ea4116.

Copy link

Node: HAPI Test (Misc) Results

 59 files   59 suites   15m 47s ⏱️
316 tests 316 ✅ 0 💤 0 ❌
398 runs  398 ✅ 0 💤 0 ❌

Results for commit 3ea4116.

Copy link

Node: HAPI Test (Smart Contract) Results

 81 files   81 suites   23m 18s ⏱️
650 tests 650 ✅ 0 💤 0 ❌
758 runs  758 ✅ 0 💤 0 ❌

Results for commit 3ea4116.

Copy link

Node: Unit Test Results

  1 531 files    1 531 suites   3h 4m 58s ⏱️
115 758 tests 115 700 ✅ 58 💤 0 ❌
123 962 runs  123 904 ✅ 58 💤 0 ❌

Results for commit 3ea4116.

Copy link

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 26s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 3ea4116.

Copy link
Contributor

@povolev15 povolev15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neeharika-Sompalli Neeharika-Sompalli merged commit 1841acf into develop Jul 17, 2024
58 of 76 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 14271-D-remove-allowances branch July 17, 2024 20:15
netopyr added a commit that referenced this pull request Jul 18, 2024
* develop: (528 commits)
  chore: Remove unused script (#14266)
  feat: use platform event post consensus (#14256)
  chore: Removed allowances modification on `TokenReject` (#14282)
  chore: Added newlines to property-files (#14275)
  test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267)
  fix: node remove test (#14237)
  feat: Add new pbj event hasher (#14226)
  chore: updated perf nightly workflow (#14263)
  docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558)
  feat: hapi tests for DAB createNode (#14228)
  feat(reconnect): log ReconnectMapStats (#14250)
  chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232)
  chore: Made StakingValidator static (#14159)
  feat: require admin key for maxAutoAssociations during contractUpdate (#14161)
  build: filter publishing by deactivating tasks (develop) (#14187)
  docs: Extend design doc for HIP-719 (#14212)
  feat: add isAssociated system contract (#14169)
  chore: File Service compiler warning fixes (#14216)
  fix: Fix casting exception for event-stream recover (#14055)
  feat: hashgraph GUI fixes (#14060)
  ...

# Conflicts:
#	hapi/build.gradle.kts
#	hapi/src/main/java/com/hedera/hapi/util/HapiUtils.java
#	hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java
#	hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/pbj/PbjConverter.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnFactory.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenCreate.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenUpdate.java
netopyr added a commit that referenced this pull request Jul 19, 2024
* develop: (22 commits)
  ci: stop release 0.51 regression (#14290)
  refactor: 14230 Removed `uptimeData` feature. (#14231)
  chore: HAPI cloneHederaProtobufs back to main (#14298)
  feat: HIP-850: HTS mutable metadata in treasury (#14204)
  chore: Remove unused script (#14266)
  feat: use platform event post consensus (#14256)
  chore: Removed allowances modification on `TokenReject` (#14282)
  chore: Added newlines to property-files (#14275)
  test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267)
  fix: node remove test (#14237)
  feat: Add new pbj event hasher (#14226)
  chore: updated perf nightly workflow (#14263)
  docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558)
  feat: hapi tests for DAB createNode (#14228)
  feat(reconnect): log ReconnectMapStats (#14250)
  chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232)
  chore: Made StakingValidator static (#14159)
  feat: require admin key for maxAutoAssociations during contractUpdate (#14161)
  build: filter publishing by deactivating tasks (develop) (#14187)
  docs: Extend design doc for HIP-719 (#14212)
  ...

# Conflicts:
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiProvider.java
#	hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't remove any allowances on TokenReject
2 participants