-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removed allowances modification on TokenReject
#14282
Conversation
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
TokenReject
TokenReject
Node: HAPI Test (Node Death Reconnect) Results3 tests 3 ✅ 5m 28s ⏱️ Results for commit 3ea4116. |
Node: HAPI Test (Token) Results 22 files 22 suites 6m 36s ⏱️ Results for commit 3ea4116. |
Node: HAPI Test (Restart) Results7 files 7 suites 8m 28s ⏱️ Results for commit 3ea4116. |
Node: HAPI Test (Crypto) Results 24 files 24 suites 14m 39s ⏱️ Results for commit 3ea4116. |
Node: HAPI Test (Misc) Results 59 files 59 suites 15m 47s ⏱️ Results for commit 3ea4116. |
Node: HAPI Test (Smart Contract) Results 81 files 81 suites 23m 18s ⏱️ Results for commit 3ea4116. |
Node: Unit Test Results 1 531 files 1 531 suites 3h 4m 58s ⏱️ Results for commit 3ea4116. |
Node: HAPI Test (Time Consuming) Results19 tests 19 ✅ 22m 26s ⏱️ Results for commit 3ea4116. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* develop: (528 commits) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) feat: add isAssociated system contract (#14169) chore: File Service compiler warning fixes (#14216) fix: Fix casting exception for event-stream recover (#14055) feat: hashgraph GUI fixes (#14060) ... # Conflicts: # hapi/build.gradle.kts # hapi/src/main/java/com/hedera/hapi/util/HapiUtils.java # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/ApiPermissionConfig.java # hedera-node/hedera-mono-service/src/main/java/com/hedera/node/app/service/mono/pbj/PbjConverter.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/TxnFactory.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenCreate.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/token/HapiTokenUpdate.java
* develop: (22 commits) ci: stop release 0.51 regression (#14290) refactor: 14230 Removed `uptimeData` feature. (#14231) chore: HAPI cloneHederaProtobufs back to main (#14298) feat: HIP-850: HTS mutable metadata in treasury (#14204) chore: Remove unused script (#14266) feat: use platform event post consensus (#14256) chore: Removed allowances modification on `TokenReject` (#14282) chore: Added newlines to property-files (#14275) test: add tests that shows the difference of transferToken and transferFrom from contracts (#14267) fix: node remove test (#14237) feat: Add new pbj event hasher (#14226) chore: updated perf nightly workflow (#14263) docs: Design doc for HIP-632 `isAuthorizedRaw` (#13558) feat: hapi tests for DAB createNode (#14228) feat(reconnect): log ReconnectMapStats (#14250) chore: add proposed `IsAssociatedSystemContractTest` test refactor (#14232) chore: Made StakingValidator static (#14159) feat: require admin key for maxAutoAssociations during contractUpdate (#14161) build: filter publishing by deactivating tasks (develop) (#14187) docs: Extend design doc for HIP-719 (#14212) ... # Conflicts: # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/api/TokenServiceApiProvider.java # hedera-node/hedera-token-service-impl/src/test/java/com/hedera/node/app/service/token/impl/test/handlers/CryptoDeleteHandlerTest.java
Fixes #14271
Removed allowances modification on
TokenReject