Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable all EVM E2E suites to run with Ethereum Calls #4375

Merged
merged 30 commits into from Mar 21, 2023

Conversation

dimitar-dinev
Copy link
Collaborator

@dimitar-dinev dimitar-dinev commented Nov 29, 2022

Description:

  • Fixes all of the failing E2Es from the contract package when run with EthereumTransaction instead of ContractCalls
    • Those tests that cannot be successfully run with both ContractCalls/EthereumTransactions have been added to EthereumSuite with the required setup for a successful EthereumTransaction execution
  • Adds the execution of Ethereum specs to the concurrent integration tests

Related issue(s):

Fixes: #4380 #4869

Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Patch coverage has no change and project coverage change: +96.34 🎉

Comparison is base (27271d6) 0.00% compared to head (bb28047) 96.34%.

❗ Current head bb28047 differs from pull request most recent head d038d4f. Consider uploading reports for the commit d038d4f to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #4375       +/-   ##
==============================================
+ Coverage           0   96.34%   +96.34%     
- Complexity         0    15211    +15211     
==============================================
  Files              0     1041     +1041     
  Lines              0    43317    +43317     
  Branches           0     4365     +4365     
==============================================
+ Hits               0    41735    +41735     
- Misses             0      822      +822     
- Partials           0      760      +760     

see 1041 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mustafauzunn mustafauzunn added the Limechain Work planned for the LimeChain team label Dec 2, 2022
dimitar-dinev and others added 4 commits December 2, 2022 11:26
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

# Conflicts:
#	test-clients/src/eet/java/EndToEndTests.java
#	test-clients/src/itest/java/ParallelIntegrationTests.java
#	test-clients/src/itest/java/SequentialIntegrationTests.java
#	test-clients/src/main/java/com/hedera/services/bdd/suites/HapiSuite.java
#	test-clients/src/main/java/com/hedera/services/bdd/suites/contract/traceability/TraceabilitySuite.java
#	test-clients/src/main/java/com/hedera/services/bdd/suites/ethereum/EthereumSuite.java
#	test-clients/src/main/java/com/hedera/services/bdd/suites/ethereum/HelloWorldEthereumSuite.java

Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
@Kalina-Todorova Kalina-Todorova linked an issue Jan 27, 2023 that may be closed by this pull request
5 tasks
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Unit Test Results

    1 202 files      1 202 suites   1h 12m 57s ⏱️
100 254 tests 100 253 ✔️ 1 💤 0
101 886 runs  101 885 ✔️ 1 💤 0

Results for commit 8553ce0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Integration Test Results

9 tests   9 ✔️  2s ⏱️
1 suites  0 💤
2 files    0
1 errors

Results for commit 8553ce0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 31, 2023

E2E Test Results

    1 files      1 suites   16m 42s ⏱️
307 tests 307 ✔️ 0 💤 0
325 runs  325 ✔️ 0 💤 0

Results for commit 8553ce0.

♻️ This comment has been updated with latest results.

@dimitar-dinev dimitar-dinev changed the title [WIP] Enable ETH tests in EndToEndTests Enable all E2E suites from contracts.precompile to run with Ethereum Calls Feb 3, 2023
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
@dimitar-dinev dimitar-dinev marked this pull request as ready for review February 3, 2023 15:40
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
# Conflicts:
#	hedera-node/hedera-mono-service/src/test/java/com/hedera/node/app/service/mono/txns/contract/ContractCallTransitionLogicTest.java
#	hedera-node/test-clients/src/itest/java/ConcurrentSuites.java
#	test-clients/src/main/java/com/hedera/services/bdd/suites/contract/hapi/ContractCallSuite.java
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
@dimitar-dinev dimitar-dinev changed the title Enable all E2E suites from contracts.precompile to run with Ethereum Calls Enable all EVM E2E suites to run with Ethereum Calls Feb 28, 2023
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Node: Unit Test Results

  1 286 files    1 286 suites   53m 41s ⏱️
97 034 tests 97 032 ✔️ 2 💤 0
98 671 runs  98 669 ✔️ 2 💤 0

Results for commit d038d4f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Node: Integration Test Results

109 tests   109 ✔️  12m 2s ⏱️
    2 suites      0 💤
    2 files        0

Results for commit d038d4f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 28, 2023

Node: E2E Test Results

    1 files      1 suites   16m 39s ⏱️
307 tests 307 ✔️ 0 💤 0
325 runs  325 ✔️ 0 💤 0

Results for commit d038d4f.

♻️ This comment has been updated with latest results.

Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
mustafauzunn
mustafauzunn previously approved these changes Mar 6, 2023
Copy link
Collaborator

@mustafauzunn mustafauzunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
stoqnkpL
stoqnkpL previously approved these changes Mar 15, 2023
# Conflicts:
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/precompile/ApproveAllowanceSuite.java
#	hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/precompile/ERCPrecompileSuite.java
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tinker-michaelj tinker-michaelj merged commit 546ba38 into develop Mar 21, 2023
8 of 9 checks passed
@tinker-michaelj tinker-michaelj deleted the check-eth-e2es branch March 21, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enable EthereumTransaction tests
5 participants