New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable all EVM E2E suites to run with Ethereum Calls #4375
Conversation
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4375 +/- ##
==============================================
+ Coverage 0 96.34% +96.34%
- Complexity 0 15211 +15211
==============================================
Files 0 1041 +1041
Lines 0 43317 +43317
Branches 0 4365 +4365
==============================================
+ Hits 0 41735 +41735
- Misses 0 822 +822
- Partials 0 760 +760 see 1041 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
# Conflicts: # test-clients/src/eet/java/EndToEndTests.java # test-clients/src/itest/java/ParallelIntegrationTests.java # test-clients/src/itest/java/SequentialIntegrationTests.java # test-clients/src/main/java/com/hedera/services/bdd/suites/HapiSuite.java # test-clients/src/main/java/com/hedera/services/bdd/suites/contract/traceability/TraceabilitySuite.java # test-clients/src/main/java/com/hedera/services/bdd/suites/ethereum/EthereumSuite.java # test-clients/src/main/java/com/hedera/services/bdd/suites/ethereum/HelloWorldEthereumSuite.java Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
EndToEndTests
contracts.precompile
to run with Ethereum Calls
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
# Conflicts: # hedera-node/hedera-mono-service/src/test/java/com/hedera/node/app/service/mono/txns/contract/ContractCallTransitionLogicTest.java # hedera-node/test-clients/src/itest/java/ConcurrentSuites.java # test-clients/src/main/java/com/hedera/services/bdd/suites/contract/hapi/ContractCallSuite.java
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
contracts.precompile
to run with Ethereum CallsSigned-off-by: Dimitar Dinev <mitkojc@gmail.com>
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
# Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/precompile/ApproveAllowanceSuite.java # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/suites/contract/precompile/ERCPrecompileSuite.java
Signed-off-by: Dimitar Dinev <mitkojc@gmail.com>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description:
contract
package when run withEthereumTransaction
instead ofContractCall
sEthereumSuite
with the required setup for a successfulEthereumTransaction
executionRelated issue(s):
Fixes: #4380 #4869