5179: Bucket.findEntryOffset() can reduce calls to getKeySize() #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
artemananiev
added
Tech Debt Reduced
artemananiev
requested review from
jasperpotts,
imalygin,
OlegMazurov,
deepak-swirlds and
jsync-swirlds
…Bucket Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
imalygin
approved these changes
Apr 4, 2023
OlegMazurov
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes to HDHM
Bucketclass:putValue()as proposed in Update DB to use new ByteBuffer API when we move to Java 17 #5188getKeySize()call is skipped for the last entry infindEntryOffset()as proposed inBucket.findEntryOffset()can reduce calls togetKeySize()#5179getValue()and the corresponding unit test - wrong offset in the bucket buffer was usedFindResultto a record and added "entryValue" field to itFixes: #5179
Fixes: #5188