Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DB to use new ByteBuffer API when we move to Java 17 #5188

Closed
swirlds-automation opened this issue Mar 3, 2023 · 1 comment · Fixed by #5949
Closed

Update DB to use new ByteBuffer API when we move to Java 17 #5188

swirlds-automation opened this issue Mar 3, 2023 · 1 comment · Fixed by #5949
Assignees
@artemananiev
Labels
Performance Issues related to performance concerns. Platform Data Structures Platform Virtual Map

Comments

@swirlds-automation
Copy link
Collaborator

There are lots of new methods in ByteBuffer between Java 12 and 17 that can make a lot of operations easier and/or faster. It would be good to do a pass and update those after we move. For example in Bucket
bucketBuffer.put(result.entryOffset,bucketBuffer,offsetOfNextEntry,sizeOfEntriesToMove);
@swirlds-automation
Copy link
Collaborator Author

migrated from:
url=https://github.com/swirlds/swirlds-platform/issues/4090
author:jasperpotts, #:4090, createdAt:2021-10-22T02:21:33Z, updatedAt=2023-02-22T00:19:02Z
labels=Performance,Platform Virtual Map,Platform Data Structures,Migration:Data

@artemananiev artemananiev mentioned this issue Apr 3, 2023
Merged
artemananiev added a commit that referenced this issue Apr 4, 2023
@artemananiev
5179: Bucket.findEntryOffset() can reduce calls to getKeySize() (#5949)
6a0fd24 
Fixes: #5179
Fixes: #5188
Reviewed-by: Ivan Malygin <ivan@swirldslabs.com>, Oleg Mazurov <oleg.mazurov@swirldslabs.com>
Signed-off-by: Artem Ananev <artem.ananev@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemananiev artemananiev

Labels
Performance Issues related to performance concerns. Platform Data Structures Platform Virtual Map
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5179: Bucket.findEntryOffset() can reduce calls to getKeySize() hashgraph/hedera-services
4 participants
@jasperpotts @artemananiev @swirlds-automation @poulok