Migrated ScheduleService to new design #6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
netopyr
added
CI:UnitTests
Modularization
hendrikebbers
previously approved these changes
Apr 25, 2023
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/ReadableStoreFactory.java
.../src/main/java/com/hedera/node/app/service/schedule/impl/handlers/ScheduleCreateHandler.java
Show resolved
Hide resolved
...rc/main/java/com/hedera/node/app/service/schedule/impl/handlers/AbstractScheduleHandler.java
Show resolved
Hide resolved
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/ReadableStoreFactory.java # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/dispatcher/MonoTransactionDispatcherTest.java
Signed-off-by: Michael Heinrichs <netopyr@users.noreply.github.com>
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/dispatcher/MonoTransactionDispatcherTest.java
jsync-swirlds
approved these changes
Apr 26, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #6243 +/- ##
==============================================
+ Coverage 67.82% 91.09% +23.26%
+ Complexity 22043 17036 -5007
==============================================
Files 1985 1294 -691
Lines 134856 48896 -85960
Branches 7582 4902 -2680
==============================================
- Hits 91469 44542 -46927
+ Misses 41917 3426 -38491
+ Partials 1470 928 -542
☔ View full report in Codecov by Sentry. |
|
SonarCloud Quality Gate failed. |
hendrikebbers
approved these changes
Apr 27, 2023
mhess-swl
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the ScheduleService to the new design:
preHandle()method generic. It has only one parametercontextand is defined inTransactionHandler.ReadableTokenStore) in the corresponding api-moduleReadableTokenStoreImpl). The classes implement the new interfaces.PreHandleContextwill become an interface in an upcoming PR. To prepare this change,FakePreHandleContextwas introduced and tests were updated. This class allows to do the switch without breaking all the tests in services.AccountAccesssoon. Instead the new interfaceReadableAccountStoreshould be used instead.